[PATCH] emacs: company: remove two build warnings

[PATCH] emacs: company: remove two build warnings

[Mark Walters]

This adds two defvars to avoid two build warnings in the notmuch emacs
code. These were both introduced (by me) in commit 827c28a0.
---

The defvar for notmuch-address-command is clearly correct as that is
defined in notmuch-address so will definitely be defined when this
code is run.

The other, for company-idle-timeout, is slightly less clear, as the
user may not use company. It feels a little unpleasant to be defining
variables outside our namespace but we do the same with
company-backends.

[Incidentally I don't think emacs compiler should complain as the
actual use (line 59) is a macro which does bind the variable in any
case.]

Best wishes

Mark




emacs/notmuch-company.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/emacs/notmuch-company.el b/emacs/notmuch-company.el
index dca6471..3e12e7a 100644
--- a/emacs/notmuch-company.el
+++ b/emacs/notmuch-company.el
@@ -37,12 +37,14 @@
 (declare-function company-mode "company")
 (declare-function company-manual-begin "company")
 (defvar company-backends)
+(defvar company-idle-delay)
 
 (declare-function notmuch-address-harvest "notmuch-address")
 (declare-function notmuch-address-harvest-trigger "notmuch-address")
 (declare-function notmuch-address-matching "notmuch-address")
 (declare-function notmuch-address--harvest-ready "notmuch-address")
 (defvar notmuch-address-completion-headers-regexp)
+(defvar notmuch-address-command)
 
 ;;;###autoload
 (defun notmuch-company-setup ()
-- 
2.1.4

Re: [PATCH] emacs: company: remove two build warnings

[David Bremner]

Mark Walters <markwalters1009@gmail.com> writes:

> This adds two defvars to avoid two build warnings in the notmuch emacs
> code. These were both introduced (by me) in commit 827c28a0.

pushed to master

d