From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH] emacs: company: remove two build warnings
Date: Sat, 28 Jan 2017 10:19:58 +0000 [thread overview]
Message-ID: <1485598799-2786-1-git-send-email-markwalters1009@gmail.com> (raw)
This adds two defvars to avoid two build warnings in the notmuch emacs
code. These were both introduced (by me) in commit 827c28a0.
---
The defvar for notmuch-address-command is clearly correct as that is
defined in notmuch-address so will definitely be defined when this
code is run.
The other, for company-idle-timeout, is slightly less clear, as the
user may not use company. It feels a little unpleasant to be defining
variables outside our namespace but we do the same with
company-backends.
[Incidentally I don't think emacs compiler should complain as the
actual use (line 59) is a macro which does bind the variable in any
case.]
Best wishes
Mark
emacs/notmuch-company.el | 2 ++
1 file changed, 2 insertions(+)
diff --git a/emacs/notmuch-company.el b/emacs/notmuch-company.el
index dca6471..3e12e7a 100644
--- a/emacs/notmuch-company.el
+++ b/emacs/notmuch-company.el
@@ -37,12 +37,14 @@
(declare-function company-mode "company")
(declare-function company-manual-begin "company")
(defvar company-backends)
+(defvar company-idle-delay)
(declare-function notmuch-address-harvest "notmuch-address")
(declare-function notmuch-address-harvest-trigger "notmuch-address")
(declare-function notmuch-address-matching "notmuch-address")
(declare-function notmuch-address--harvest-ready "notmuch-address")
(defvar notmuch-address-completion-headers-regexp)
+(defvar notmuch-address-command)
;;;###autoload
(defun notmuch-company-setup ()
--
2.1.4
next reply other threads:[~2017-01-28 10:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 10:19 Mark Walters [this message]
2017-02-23 12:58 ` [PATCH] emacs: company: remove two build warnings David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485598799-2786-1-git-send-email-markwalters1009@gmail.com \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).