From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id DE0F06DE00E8 for ; Sat, 28 Jan 2017 02:20:20 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.068 X-Spam-Level: X-Spam-Status: No, score=0.068 tagged_above=-999 required=5 tests=[AWL=-0.062, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1PiTJYC5r33x for ; Sat, 28 Jan 2017 02:20:20 -0800 (PST) Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by arlo.cworth.org (Postfix) with ESMTPS id 06D706DE00AC for ; Sat, 28 Jan 2017 02:20:19 -0800 (PST) Received: by mail-wm0-f42.google.com with SMTP id d140so20273363wmd.0 for ; Sat, 28 Jan 2017 02:20:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=5reeeEQ088Wl0vmygchrI3bck3q2Ek1n/tZQ66MektE=; b=WeBVh/D+oePit3pVvXi7POdryybhXYox1kKsLiPVk5uRUXyAEgb6cHAJETHMsYfuQY x9v/GfIgI4pNo2qBgBAHuftGZHBQ3cpfTLspk6YBv5Qcu3XN6PYyM1lONIAaiqud37TF xWVX5oHGJFRUgcr4cL4f80yLn+Q2UKUPD+kkMObxXNaRbrbJRDkQmM06am8d45XWco2g xul9Lkk3eWhjKQT5csfCmfpVlQ+Tc0oBDVvQMeoaFjWGIJQ0Ybqfh0TbyouwBjh9Fh9o 2X4NYyjSWqfsxA2BepQYTjXKBb1W6eUC7MpBx3l/ApXc2ILqwnrF6y8iYl18FYI+3ko6 R5mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5reeeEQ088Wl0vmygchrI3bck3q2Ek1n/tZQ66MektE=; b=So8TNprCxzTSueXlYN0qPGlJ5xSO1IjfSS06s+a8WiudIgCOA3462M1+wKla+wQZDb YBWY+UAUsvcPBa/VBpjHrkDP6X5NJ97P7LEjvh4L5hd223k11Aac/asal+SMKrgB9ztf yXnZCCPYsLCPqLVVIxBYDspLfloiKDdUSG8jhQE0RLobrGmffmGfqhvaSAPQwUcNWks6 HoILVDL/oCLHE7+6CqUw0iuB9fiOZWNDsAvlI7cgXfAwKtIhEmj+XYC1+4LMtm6ubIkI Y3G4Tbp58S6R/MOZuEkLoKZ57wIanwMt5R/3112sVsDGcKSgXCQJ5DQqUsY2do+cSL1U 9xsA== X-Gm-Message-State: AIkVDXICVEB4Nvxj31X6QR0hDCOpRHK4ntFAShVRUpdq2Fn6SlwOb2cQYWpVNY7ZzPCz/Q== X-Received: by 10.223.170.3 with SMTP id p3mr12781236wrd.100.1485598818256; Sat, 28 Jan 2017 02:20:18 -0800 (PST) Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162]) by smtp.gmail.com with ESMTPSA id q12sm8200170wmd.8.2017.01.28.02.20.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Jan 2017 02:20:17 -0800 (PST) From: Mark Walters To: notmuch@notmuchmail.org Subject: [PATCH] emacs: company: remove two build warnings Date: Sat, 28 Jan 2017 10:19:58 +0000 Message-Id: <1485598799-2786-1-git-send-email-markwalters1009@gmail.com> X-Mailer: git-send-email 2.1.4 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jan 2017 10:20:21 -0000 This adds two defvars to avoid two build warnings in the notmuch emacs code. These were both introduced (by me) in commit 827c28a0. --- The defvar for notmuch-address-command is clearly correct as that is defined in notmuch-address so will definitely be defined when this code is run. The other, for company-idle-timeout, is slightly less clear, as the user may not use company. It feels a little unpleasant to be defining variables outside our namespace but we do the same with company-backends. [Incidentally I don't think emacs compiler should complain as the actual use (line 59) is a macro which does bind the variable in any case.] Best wishes Mark emacs/notmuch-company.el | 2 ++ 1 file changed, 2 insertions(+) diff --git a/emacs/notmuch-company.el b/emacs/notmuch-company.el index dca6471..3e12e7a 100644 --- a/emacs/notmuch-company.el +++ b/emacs/notmuch-company.el @@ -37,12 +37,14 @@ (declare-function company-mode "company") (declare-function company-manual-begin "company") (defvar company-backends) +(defvar company-idle-delay) (declare-function notmuch-address-harvest "notmuch-address") (declare-function notmuch-address-harvest-trigger "notmuch-address") (declare-function notmuch-address-matching "notmuch-address") (declare-function notmuch-address--harvest-ready "notmuch-address") (defvar notmuch-address-completion-headers-regexp) +(defvar notmuch-address-command) ;;;###autoload (defun notmuch-company-setup () -- 2.1.4