From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: add some exclude tests
Date: Sun, 18 Mar 2012 11:08:08 -0700 [thread overview]
Message-ID: <87pqc9ye7r.fsf@servo.finestructure.net> (raw)
In-Reply-To: <1332091381-16797-1-git-send-email-markwalters1009@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 842 bytes --]
On Sun, 18 Mar 2012 17:23:01 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
> Here are some tests for search exclude working in a systematic fashion
> as suggested by Austin.
Awesome. More tests = good.
> In principle I think something like the generate_thread function could
> go in to test-lib.sh, but it would need to be written by someone much
> familiar with bash quoting than I am.
Yeah, that's probably a good idea. It seems generally useful.
> At the moment I have left the current exclude tests in the "search"
> test: should they be moved here?
I would probably put all of the exclude tests (even count/show exclude
tests?) into one test script. Might make debugging a bit easier down
the line. But there are also plenty of tests that fall under multiple
categories, so it's kind of hard to just pick one.
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2012-03-18 18:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 18:42 [PATCH 0/5] Move --no-exclude to --exclude=(true|false|flag) Mark Walters
2012-03-15 18:42 ` [PATCH 1/5] lib: change default for notmuch_query_set_omit_excluded Mark Walters
2012-03-15 18:42 ` [PATCH 2/5] cli: move count to the new --exclude=(true|false|flag) naming scheme Mark Walters
2012-03-15 18:42 ` [PATCH 3/5] cli: move search to the new --exclude= " Mark Walters
2012-03-17 15:50 ` Austin Clements
2012-03-17 19:49 ` Jameson Graef Rollins
2012-03-18 17:23 ` [PATCH] test: add some exclude tests Mark Walters
2012-03-18 18:08 ` Jameson Graef Rollins [this message]
2012-03-15 18:42 ` [PATCH 4/5] cli: move show to the new --exclude= option naming scheme Mark Walters
2012-03-17 16:51 ` Austin Clements
2012-03-18 17:30 ` Mark Walters
2012-03-15 18:42 ` [PATCH 5/5] emacs: make show set --exclude=flag Mark Walters
2012-03-17 16:52 ` Austin Clements
2012-03-17 6:02 ` [PATCH 0/5] Move --no-exclude to --exclude=(true|false|flag) Jameson Graef Rollins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqc9ye7r.fsf@servo.finestructure.net \
--to=jrollins@finestructure.net \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).