From: Austin Clements <amdragon@MIT.EDU>
To: Mark Walters <markwalters1009@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 3/5] cli: move search to the new --exclude= naming scheme.
Date: Sat, 17 Mar 2012 11:50:23 -0400 [thread overview]
Message-ID: <20120317155023.GH2670@mit.edu> (raw)
In-Reply-To: <1331836925-31437-4-git-send-email-markwalters1009@gmail.com>
Quoth Mark Walters on Mar 15 at 6:42 pm:
> This commit replaces the --no-exclude option with a
> --exclude=(true|false|flag) option. The default is to omit the
> excluded messages.
>
> The flag option only makes sense if output=summary (as otherwise there
> is nowhere to print the flag). In summary output exclude=false and
> exclude=flag give almost identical output:
> they differ in that with the exclude=flag option the match count
> (i.e., the x in [x/n] in the output) is the number of matching
> non-excluded messages rather than the number of matching messages.
>
> Note this changes the default for output=summary when no --exclude=
> option is given: it used to default to flag and now defaults to true
> (i.e. omit excluded messages). This is neccesary to keep the cli
> output uncluttered and for speed reasons.
> ---
Code looks good, but I think there need to be a few more tests. In
particular, I think we need all 10 valid combinations of
* --output=summary or --output=messages (those two are probably
enough)
* The three types of exclude (or two for --output=messages)
* Whether or not an excluded term is in the query
Finally, the corpus should have three threads of interest: a thread
with no excluded messages, a thread with both excluded and
non-excluded messages, and a thread consisting entirely of excluded
messages.
We already have many of these, but it would be good to systematically
cover the full gamut of possibilities.
next prev parent reply other threads:[~2012-03-17 15:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 18:42 [PATCH 0/5] Move --no-exclude to --exclude=(true|false|flag) Mark Walters
2012-03-15 18:42 ` [PATCH 1/5] lib: change default for notmuch_query_set_omit_excluded Mark Walters
2012-03-15 18:42 ` [PATCH 2/5] cli: move count to the new --exclude=(true|false|flag) naming scheme Mark Walters
2012-03-15 18:42 ` [PATCH 3/5] cli: move search to the new --exclude= " Mark Walters
2012-03-17 15:50 ` Austin Clements [this message]
2012-03-17 19:49 ` Jameson Graef Rollins
2012-03-18 17:23 ` [PATCH] test: add some exclude tests Mark Walters
2012-03-18 18:08 ` Jameson Graef Rollins
2012-03-15 18:42 ` [PATCH 4/5] cli: move show to the new --exclude= option naming scheme Mark Walters
2012-03-17 16:51 ` Austin Clements
2012-03-18 17:30 ` Mark Walters
2012-03-15 18:42 ` [PATCH 5/5] emacs: make show set --exclude=flag Mark Walters
2012-03-17 16:52 ` Austin Clements
2012-03-17 6:02 ` [PATCH 0/5] Move --no-exclude to --exclude=(true|false|flag) Jameson Graef Rollins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120317155023.GH2670@mit.edu \
--to=amdragon@mit.edu \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).