unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH 0/5] Move --no-exclude to --exclude=(true|false|flag)
Date: Thu, 15 Mar 2012 18:42:00 +0000	[thread overview]
Message-ID: <1331836925-31437-1-git-send-email-markwalters1009@gmail.com> (raw)

This series changes the --no-exclude options to count, search and show
to --exclude=(true|false|flag). It also changes the default to true
rather than flag for speed and for uncluttered command line output.

This series replaces the series
id:"1330779918-28024-1-git-send-email-markwalters1009@gmail.com". Jani
suggested the --exclude= rather than --with-excluded approach as being
both clearer and easier to extend.

It is intend to apply on top of the bugfix series
id:"1331728014-32698-1-git-send-email-markwalters1009@gmail.com".

There should be no significant logic change (i.e. the logic in the lib
is unchanged) but the defaults for the command lines are different.

The general idea is that when complete threads are requested then we
always return complete threads including any messages matching the
exclude tags (where appropriate these are flagged excluded), but we
may not return threads that only match in excluded messages.

The rationale is that it is awkward to deal with a thread with
"missing" messages.

Best wishes

Mark

Mark Walters (5):
  lib: change default for notmuch_query_set_omit_excluded
  cli: move count to the new --exclude=(true|false|flag) naming scheme.
  cli: move search to the new --exclude= naming scheme.
  cli: move show to the new --exclude= option naming scheme.
  emacs: make show set --exclude=flag

 emacs/notmuch-show.el     |    6 ++++--
 lib/notmuch.h             |   11 ++++++-----
 lib/query.cc              |   10 +++++-----
 man/man1/notmuch-count.1  |    5 +++--
 man/man1/notmuch-search.1 |   12 +++++++++---
 man/man1/notmuch-show.1   |   16 ++++++++++++++--
 notmuch-client.h          |    1 +
 notmuch-count.c           |   17 ++++++++++++-----
 notmuch-search.c          |   32 +++++++++++++++++++++++---------
 notmuch-show.c            |   39 +++++++++++++++++++++++++++++----------
 test/count                |    4 ++--
 test/search               |   13 ++++++-------
 12 files changed, 114 insertions(+), 52 deletions(-)

-- 
1.7.9.1

             reply	other threads:[~2012-03-15 18:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-15 18:42 Mark Walters [this message]
2012-03-15 18:42 ` [PATCH 1/5] lib: change default for notmuch_query_set_omit_excluded Mark Walters
2012-03-15 18:42 ` [PATCH 2/5] cli: move count to the new --exclude=(true|false|flag) naming scheme Mark Walters
2012-03-15 18:42 ` [PATCH 3/5] cli: move search to the new --exclude= " Mark Walters
2012-03-17 15:50   ` Austin Clements
2012-03-17 19:49     ` Jameson Graef Rollins
2012-03-18 17:23     ` [PATCH] test: add some exclude tests Mark Walters
2012-03-18 18:08       ` Jameson Graef Rollins
2012-03-15 18:42 ` [PATCH 4/5] cli: move show to the new --exclude= option naming scheme Mark Walters
2012-03-17 16:51   ` Austin Clements
2012-03-18 17:30     ` Mark Walters
2012-03-15 18:42 ` [PATCH 5/5] emacs: make show set --exclude=flag Mark Walters
2012-03-17 16:52   ` Austin Clements
2012-03-17  6:02 ` [PATCH 0/5] Move --no-exclude to --exclude=(true|false|flag) Jameson Graef Rollins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331836925-31437-1-git-send-email-markwalters1009@gmail.com \
    --to=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).