From: Protesilaos Stavrou <info@protesilaos.com>
To: Tomi Ollila <tomi.ollila@iki.fi>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: use new face for notmuch-jump and related
Date: Tue, 25 May 2021 22:53:10 +0300 [thread overview]
Message-ID: <87pmxebnfd.fsf@protesilaos.com> (raw)
In-Reply-To: <m2mtsi1tz7.fsf@guru.guru-group.fi>
On 2021-05-25, 22:41 +0300, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> On Fri, May 21 2021, Protesilaos Stavrou wrote:
>
>> The minibuffer-prompt face that was used before made it impossible to
>> differentiate between two distinct UI elements: (i) the prompt's text
>> which itself cannot be acted upon, (ii) the actionable keys used to
>> jump to searches/tags.
>>
>> The use of a named face, notmuch-jump-key, makes it possible for users
>> or theme developers to apply properties that are specific to each of
>> those two cases.
>>
>> In the interest of backward compatibility, the new face inherits from
>> minibuffer-prompt.
>
> This looks like a good change. How does one test this
> and see the difference?
>
> Tomi
Hello Tomi!
By default there will be no visual difference with how it was before.
Just so that we do not upset existing users.
Something like this can be used to change the new face (for demo
purposes):
(set-face-attribute 'notmuch-jump-key nil :background "blue" :foreground "white" :weight 'bold)
All the best,
Prot
--
Protesilaos Stavrou
https://protesilaos.com
next prev parent reply other threads:[~2021-05-25 20:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 16:55 [PATCH] emacs: use new face for notmuch-jump and related Protesilaos Stavrou
2021-05-25 19:41 ` Tomi Ollila
2021-05-25 19:53 ` Protesilaos Stavrou [this message]
2021-06-27 16:39 ` David Bremner
2021-06-27 17:29 ` Protesilaos Stavrou
2021-07-07 10:28 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmxebnfd.fsf@protesilaos.com \
--to=info@protesilaos.com \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).