Re: [PATCH] emacs: use new face for notmuch-jump and related

[Protesilaos Stavrou <info@protesilaos.com>]

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

On 2021-06-27, 13:39 -0300, David Bremner <david@tethera.net> wrote:

> Protesilaos Stavrou <info@protesilaos.com> writes:
>
>> The use of a named face, notmuch-jump-key, makes it possible for users
>> or theme developers to apply properties that are specific to each of
>> those two cases.
>>
>
> applied to master, thanks

You are welcome!  I just noticed a mistake from my side.  Please refer
to the attached patch.  Shall I start a new thread of will this one
suffice?

-- 
Protesilaos Stavrou
https://protesilaos.com

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Amend-commit-5cc106b0-about-notmuch-jump-key-face.patch --]
[-- Type: text/x-patch, Size: 1244 bytes --]

From 7a83f7e978ab47ebd75438af3ede6280c870f529 Mon Sep 17 00:00:00 2001
Message-Id: <7a83f7e978ab47ebd75438af3ede6280c870f529.1624814747.git.info@protesilaos.com>
From: Protesilaos Stavrou <info@protesilaos.com>
Date: Sun, 27 Jun 2021 20:25:26 +0300
Subject: [PATCH] Amend commit 5cc106b0 about notmuch-jump-key face

The intent of that face is to allow users/themes to differentiate the
text of the minibuffer prompt from the keys that are associated with
jump actions.  Commit 5cc106b0 correctly introduced the new
'notmuch-jump-key' face for keys, but mistakenly applied it to the
prompt as well.
---
 emacs/notmuch-jump.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/emacs/notmuch-jump.el b/emacs/notmuch-jump.el
index e228c8a2..5ec8eb9c 100644
--- a/emacs/notmuch-jump.el
+++ b/emacs/notmuch-jump.el
@@ -93,7 +93,7 @@ (defun notmuch-jump (action-map prompt)
 	    (buffer-string)))
 	 (full-prompt
 	  (concat table "\n\n"
-		  (propertize prompt 'face 'notmuch-jump-key)))
+		  (propertize prompt 'face 'minibuffer-prompt)))
 	 ;; By default, the minibuffer applies the minibuffer face to
 	 ;; the entire prompt.  However, we want to clearly
 	 ;; distinguish bindings (which we put in the prompt face
-- 
2.32.0


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]