From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4DlHIZBXrWByEgAAgWs5BA (envelope-from ) for ; Tue, 25 May 2021 22:01:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 0KsHHZBXrWB1EgAA1q6Kng (envelope-from ) for ; Tue, 25 May 2021 20:01:20 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 61D751A222 for ; Tue, 25 May 2021 22:01:19 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id A27802AFF8; Tue, 25 May 2021 16:01:15 -0400 (EDT) Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [217.70.178.240]) by mail.notmuchmail.org (Postfix) with ESMTPS id A85922AA5B for ; Tue, 25 May 2021 16:01:08 -0400 (EDT) Received: from relay2-d.mail.gandi.net (unknown [217.70.183.194]) by mslow1.mail.gandi.net (Postfix) with ESMTP id C58D2C3E87 for ; Tue, 25 May 2021 19:53:34 +0000 (UTC) Received: (Authenticated sender: public@protesilaos.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id DBC8A40007; Tue, 25 May 2021 19:53:12 +0000 (UTC) From: Protesilaos Stavrou To: Tomi Ollila Subject: Re: [PATCH] emacs: use new face for notmuch-jump and related In-Reply-To: References: User-Agent: Notmuch/0.32 (https://notmuchmail.org) Emacs/28.0.50 (x86_64-pc-linux-gnu) Date: Tue, 25 May 2021 22:53:10 +0300 Message-ID: <87pmxebnfd.fsf@protesilaos.com> MIME-Version: 1.0 Message-ID-Hash: 7XJTMWHZ2LY6JPYNU7VFUKZDQIKB3PKY X-Message-ID-Hash: 7XJTMWHZ2LY6JPYNU7VFUKZDQIKB3PKY X-MailFrom: info@protesilaos.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: notmuch@notmuchmail.org X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621972879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zvt3lFLXmHugb1sG4sgERXlZauqtdoRGu7cWqjWWN5k=; b=lCIVTfQeuAzE5DK0SzgKxSf7GBBA/t84BFFrT0U3EG2nuxmfC+5+QQYOvIE6HTyCL0LjHl lNvHANDYIjCsjFUxknIarQ2+9FOzNnMoQxT+X1C5h41IpYKUtzJLLRx9V5LFw8yj6F+m+z IAr9G74amDzh+meaMSWPrOHyRI+F0FL98itV0NLts7RaqX+rsZvh2+IZLfvW79XShYC9cn JNotgqdDfwUxF23B/tqWs09q7HpKrQqSm7hMFvTquTw8AvqYq/pecihwIpO1QTHtciWbSh /ndY87D4TeOJ+Vh4L+pleTxmBEo0HIVkEQJK6U17XxULCZWucrtwMRFeR/W7+A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621972879; a=rsa-sha256; cv=none; b=MxrfCwchcoizFOERPUTLGNdlLnz0brlXnh7bgnlHR86Jum36B2SRstn81xxU6w/ojhmuaD dxpQME1eZfR4Qle/8mYUbBw5LcuCvm+Ypy1iW6nPw/xv6pGbLPxlKc55CwCE9GltrjQiUG fLXakMcTh8uYj+LyySsOXc+S48yNKO01/JBSSURqaZL1xK3AeVixYaD+FU52XT3TPyUqtY XByGaZEHgnipIXr48s7eKEyGhewQ4bJVHvdaYyzxqJ7PcCL3cJj7AmiYs4DlVlmOibpBUB +XuqLYxDRg2XN7Bygi/0JFljFPUrZIR3u0/40WX7RG1kUwO+iGDFzKRXQ1RQlQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.07 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 61D751A222 X-Spam-Score: -2.07 X-Migadu-Scanner: scn1.migadu.com X-TUID: 3khn22j36131 On 2021-05-25, 22:41 +0300, Tomi Ollila wrote: > On Fri, May 21 2021, Protesilaos Stavrou wrote: > >> The minibuffer-prompt face that was used before made it impossible to >> differentiate between two distinct UI elements: (i) the prompt's text >> which itself cannot be acted upon, (ii) the actionable keys used to >> jump to searches/tags. >> >> The use of a named face, notmuch-jump-key, makes it possible for users >> or theme developers to apply properties that are specific to each of >> those two cases. >> >> In the interest of backward compatibility, the new face inherits from >> minibuffer-prompt. > > This looks like a good change. How does one test this > and see the difference? > > Tomi Hello Tomi! By default there will be no visual difference with how it was before. Just so that we do not upset existing users. Something like this can be used to change the new face (for demo purposes): (set-face-attribute 'notmuch-jump-key nil :background "blue" :foreground "white" :weight 'bold) All the best, Prot -- Protesilaos Stavrou https://protesilaos.com