From: David Bremner <david@tethera.net>
To: Protesilaos Stavrou <info@protesilaos.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: use new face for notmuch-jump and related
Date: Wed, 07 Jul 2021 07:28:14 -0300 [thread overview]
Message-ID: <874kd65sg1.fsf@tethera.net> (raw)
In-Reply-To: <87im1z43o9.fsf@protesilaos.com>
Protesilaos Stavrou <info@protesilaos.com> writes:
> On 2021-06-27, 13:39 -0300, David Bremner <david@tethera.net> wrote:
>
>> Protesilaos Stavrou <info@protesilaos.com> writes:
>>
>>> The use of a named face, notmuch-jump-key, makes it possible for users
>>> or theme developers to apply properties that are specific to each of
>>> those two cases.
>>>
>>
>> applied to master, thanks
>
> You are welcome! I just noticed a mistake from my side. Please refer
> to the attached patch. Shall I start a new thread of will this one
> suffice?
I guess you should start a new thread. Please use a more informative
patch subject; you can mention the commit you are updating in the body
of the commit message. I would avoid the word "amend" because that has a
specific technical meaning in the context of git, and we're not going to
rewrite published history.
Thanks
David
prev parent reply other threads:[~2021-07-07 10:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 16:55 [PATCH] emacs: use new face for notmuch-jump and related Protesilaos Stavrou
2021-05-25 19:41 ` Tomi Ollila
2021-05-25 19:53 ` Protesilaos Stavrou
2021-06-27 16:39 ` David Bremner
2021-06-27 17:29 ` Protesilaos Stavrou
2021-07-07 10:28 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kd65sg1.fsf@tethera.net \
--to=david@tethera.net \
--cc=info@protesilaos.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).