From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8NSUCma22GDqJgEAgWs5BA (envelope-from ) for ; Sun, 27 Jun 2021 19:33:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gJM2Bma22GBhcwAAbx9fmQ (envelope-from ) for ; Sun, 27 Jun 2021 17:33:26 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5BB4D1DA3D for ; Sun, 27 Jun 2021 19:33:25 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 56481290FC; Sun, 27 Jun 2021 13:33:21 -0400 (EDT) Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [217.70.178.240]) by mail.notmuchmail.org (Postfix) with ESMTPS id 281B1290D9 for ; Sun, 27 Jun 2021 13:33:19 -0400 (EDT) Received: from relay7-d.mail.gandi.net (unknown [217.70.183.200]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 1D274C74F9 for ; Sun, 27 Jun 2021 17:29:35 +0000 (UTC) Received: (Authenticated sender: public@protesilaos.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 3216F20005; Sun, 27 Jun 2021 17:29:11 +0000 (UTC) From: Protesilaos Stavrou To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: use new face for notmuch-jump and related In-Reply-To: <87lf6vxnw1.fsf@tethera.net> References: <87lf6vxnw1.fsf@tethera.net> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Emacs/28.0.50 (x86_64-pc-linux-gnu) Date: Sun, 27 Jun 2021 20:29:10 +0300 Message-ID: <87im1z43o9.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Message-ID-Hash: 2QCWBP5X22SITIOCPJ7AFJPGH2F2NVQ3 X-Message-ID-Hash: 2QCWBP5X22SITIOCPJ7AFJPGH2F2NVQ3 X-MailFrom: info@protesilaos.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624815205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=whPIu1GtL9HZH7aWM8FRqkwRCRVDYZonQVTWYMIUpuM=; b=OgPhiNJaOzYAbqROd9a7oiIAi7j/H5nlKFlDxAS11Fba2cEZQ/6zTgAhwD0Bgj6uDm6sl6 5FgnWi1UYOkq874u8qlNVgkxxqVn1WBFYnwbCj2xo8GAmBH3ELEJFhNx67gti6Oza/GIHn +xN3Nc7HwmbmAq4qrGs5aBj93SI7NtjjggCna4Du+KD7iP9NSgm8DhZY4FTAF7Yh4prbJX P7ZxwfDe0nKt+95PEomPXp/BgIu49Y/tj28n6+JECpXXxr6zYEzq4WE4br4soFOi/8qc2b 2KHwqaWKwENP7uS68uF8/NliELDkODkj86WzNdjQ73sl/WWsFpOr3CF3A8B9KQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624815205; a=rsa-sha256; cv=none; b=EcdMcbSBLN2l7sH4+keCuhQZo9sv9kADL5pOHT3X48tN/HQNRrMuhpkJdzTkc3jqcQj/cK uQlT4sT4Jk0jhe8cOcntN30ztNAl3J6y+lPf7eRVwAjIGD7h/IcnRDtWdphtkvNh31qaqM SBmZIkZJHLKM5jXj71ni9xqUhIhu5urURAJluwNT+mp0nFSQmPi+xrpVjXVro92OKscCYG fl8u94gfEbVFrjBYm/OQqQJwl7KBC9PoNon3fkkcPLpJtUpYU6dq/aZUWPlLv9NAPCJn6n ALU8lJoTMDXtP79MRuXxVvhX0hpOwoZSHtsK5O11bOmOX6Ceq81Z+wARH4d7/g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.02 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 5BB4D1DA3D X-Spam-Score: -2.02 X-Migadu-Scanner: scn1.migadu.com X-TUID: /C86MVIEAZDh --=-=-= Content-Type: text/plain On 2021-06-27, 13:39 -0300, David Bremner wrote: > Protesilaos Stavrou writes: > >> The use of a named face, notmuch-jump-key, makes it possible for users >> or theme developers to apply properties that are specific to each of >> those two cases. >> > > applied to master, thanks You are welcome! I just noticed a mistake from my side. Please refer to the attached patch. Shall I start a new thread of will this one suffice? -- Protesilaos Stavrou https://protesilaos.com --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Amend-commit-5cc106b0-about-notmuch-jump-key-face.patch >From 7a83f7e978ab47ebd75438af3ede6280c870f529 Mon Sep 17 00:00:00 2001 Message-Id: <7a83f7e978ab47ebd75438af3ede6280c870f529.1624814747.git.info@protesilaos.com> From: Protesilaos Stavrou Date: Sun, 27 Jun 2021 20:25:26 +0300 Subject: [PATCH] Amend commit 5cc106b0 about notmuch-jump-key face The intent of that face is to allow users/themes to differentiate the text of the minibuffer prompt from the keys that are associated with jump actions. Commit 5cc106b0 correctly introduced the new 'notmuch-jump-key' face for keys, but mistakenly applied it to the prompt as well. --- emacs/notmuch-jump.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/emacs/notmuch-jump.el b/emacs/notmuch-jump.el index e228c8a2..5ec8eb9c 100644 --- a/emacs/notmuch-jump.el +++ b/emacs/notmuch-jump.el @@ -93,7 +93,7 @@ (defun notmuch-jump (action-map prompt) (buffer-string))) (full-prompt (concat table "\n\n" - (propertize prompt 'face 'notmuch-jump-key))) + (propertize prompt 'face 'minibuffer-prompt))) ;; By default, the minibuffer applies the minibuffer face to ;; the entire prompt. However, we want to clearly ;; distinguish bindings (which we put in the prompt face -- 2.32.0 --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --=-=-=--