* bash completion install location
@ 2016-10-04 11:09 David Bremner
2016-10-22 10:15 ` Jani Nikula
2016-10-22 10:59 ` Tomi Ollila
0 siblings, 2 replies; 6+ messages in thread
From: David Bremner @ 2016-10-04 11:09 UTC (permalink / raw)
To: notmuch
Debian complains about /etc/bash_completion.d begin obsolete and also
claims that /usr/share/bash-completion/completions is the right location
[1]. Can someone who uses bash (ideally also some non-Debian platform)
please confirm or deny this?
[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=776954
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bash completion install location
2016-10-04 11:09 bash completion install location David Bremner
@ 2016-10-22 10:15 ` Jani Nikula
2016-10-22 10:59 ` Tomi Ollila
1 sibling, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2016-10-22 10:15 UTC (permalink / raw)
To: David Bremner, notmuch
On Tue, 04 Oct 2016, David Bremner <david@tethera.net> wrote:
> Debian complains about /etc/bash_completion.d begin obsolete and also
> claims that /usr/share/bash-completion/completions is the right location
> [1]. Can someone who uses bash (ideally also some non-Debian platform)
> please confirm or deny this?
I don't know about one or the other location being "obsolete" or
"right", but as a data point, both 'dpkg -S /etc/bash_completion.d' and
'dpkg -S /usr/share/bash-completion/completions' list plenty of packages
on Debian Jessie. Looking at upstream, the former seems to be used,
perhaps the latter is a Debian thing.
Not very helpful, is it? :/
BR,
Jani.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bash completion install location
2016-10-04 11:09 bash completion install location David Bremner
2016-10-22 10:15 ` Jani Nikula
@ 2016-10-22 10:59 ` Tomi Ollila
2017-03-12 17:24 ` [PATCH] configure: change default bash completion location to /usr/share David Bremner
1 sibling, 1 reply; 6+ messages in thread
From: Tomi Ollila @ 2016-10-22 10:59 UTC (permalink / raw)
To: David Bremner, notmuch
On Tue, Oct 04 2016, David Bremner <david@tethera.net> wrote:
> Debian complains about /etc/bash_completion.d begin obsolete and also
> claims that /usr/share/bash-completion/completions is the right location
> [1]. Can someone who uses bash (ideally also some non-Debian platform)
> please confirm or deny this?
On fedora 24 the location is /usr/share/bash-completion/...
Also
https://github.com/scop/bash-completion/blob/master/CHANGES#L845
says that layout change for 1.90 is that... and notmuch requires
bash-completion 1.90+ for bash completion to be included
> [1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=776954
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] configure: change default bash completion location to /usr/share
2016-10-22 10:59 ` Tomi Ollila
@ 2017-03-12 17:24 ` David Bremner
2017-03-12 17:27 ` Tomi Ollila
2017-03-25 15:07 ` David Bremner
0 siblings, 2 replies; 6+ messages in thread
From: David Bremner @ 2017-03-12 17:24 UTC (permalink / raw)
To: Tomi Ollila, David Bremner, notmuch
At least Fedora and Debian now use
/usr/share/bash-completion/completions now. Apparently
/etc/bash_completion.d will be phased out at some point in the future.
---
configure | 4 ++--
debian/notmuch.install | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index e16a9b76..0de354ea 100755
--- a/configure
+++ b/configure
@@ -132,7 +132,7 @@ Fine tuning of some installation directories is available:
--sysconfdir=DIR Read-only single-machine data [PREFIX/etc]
--emacslispdir=DIR Emacs code [PREFIX/share/emacs/site-lisp]
--emacsetcdir=DIR Emacs miscellaneous files [PREFIX/share/emacs/site-lisp]
- --bashcompletiondir=DIR Bash completions files [SYSCONFDIR/bash_completion.d]
+ --bashcompletiondir=DIR Bash completions files [PREFIX/share/bash-completion/completions]
--zshcompletiondir=DIR Zsh completions files [PREFIX/share/zsh/functions/Completion/Unix]
Some features can be disabled (--with-feature=no is equivalent to
@@ -1030,7 +1030,7 @@ HAVE_DOXYGEN=${have_doxygen}
desktop_dir = \$(prefix)/share/applications
# The directory to which bash completions files should be installed
-bash_completion_dir = ${BASHCOMPLETIONDIR:=\$(sysconfdir)/bash_completion.d}
+bash_completion_dir = ${BASHCOMPLETIONDIR:=\$(prefix)/share/bash-completion/completions}
# The directory to which zsh completions files should be installed
zsh_completion_dir = ${ZSHCOMLETIONDIR:=\$(prefix)/share/zsh/functions/Completion/Unix}
diff --git a/debian/notmuch.install b/debian/notmuch.install
index 86e891d4..31b9a37e 100644
--- a/debian/notmuch.install
+++ b/debian/notmuch.install
@@ -1,3 +1,3 @@
usr/bin
usr/share/man
-etc/bash_completion.d
+usr/share/bash-completion
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] configure: change default bash completion location to /usr/share
2017-03-12 17:24 ` [PATCH] configure: change default bash completion location to /usr/share David Bremner
@ 2017-03-12 17:27 ` Tomi Ollila
2017-03-25 15:07 ` David Bremner
1 sibling, 0 replies; 6+ messages in thread
From: Tomi Ollila @ 2017-03-12 17:27 UTC (permalink / raw)
To: David Bremner, David Bremner, notmuch
On Sun, Mar 12 2017, David Bremner <david@tethera.net> wrote:
> At least Fedora and Debian now use
> /usr/share/bash-completion/completions now. Apparently
> /etc/bash_completion.d will be phased out at some point in the future.
> ---
LGTM (from keyboard of 20+ year zsh user)
Tomi
> configure | 4 ++--
> debian/notmuch.install | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index e16a9b76..0de354ea 100755
> --- a/configure
> +++ b/configure
> @@ -132,7 +132,7 @@ Fine tuning of some installation directories is available:
> --sysconfdir=DIR Read-only single-machine data [PREFIX/etc]
> --emacslispdir=DIR Emacs code [PREFIX/share/emacs/site-lisp]
> --emacsetcdir=DIR Emacs miscellaneous files [PREFIX/share/emacs/site-lisp]
> - --bashcompletiondir=DIR Bash completions files [SYSCONFDIR/bash_completion.d]
> + --bashcompletiondir=DIR Bash completions files [PREFIX/share/bash-completion/completions]
> --zshcompletiondir=DIR Zsh completions files [PREFIX/share/zsh/functions/Completion/Unix]
>
> Some features can be disabled (--with-feature=no is equivalent to
> @@ -1030,7 +1030,7 @@ HAVE_DOXYGEN=${have_doxygen}
> desktop_dir = \$(prefix)/share/applications
>
> # The directory to which bash completions files should be installed
> -bash_completion_dir = ${BASHCOMPLETIONDIR:=\$(sysconfdir)/bash_completion.d}
> +bash_completion_dir = ${BASHCOMPLETIONDIR:=\$(prefix)/share/bash-completion/completions}
>
> # The directory to which zsh completions files should be installed
> zsh_completion_dir = ${ZSHCOMLETIONDIR:=\$(prefix)/share/zsh/functions/Completion/Unix}
> diff --git a/debian/notmuch.install b/debian/notmuch.install
> index 86e891d4..31b9a37e 100644
> --- a/debian/notmuch.install
> +++ b/debian/notmuch.install
> @@ -1,3 +1,3 @@
> usr/bin
> usr/share/man
> -etc/bash_completion.d
> +usr/share/bash-completion
> --
> 2.11.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] configure: change default bash completion location to /usr/share
2017-03-12 17:24 ` [PATCH] configure: change default bash completion location to /usr/share David Bremner
2017-03-12 17:27 ` Tomi Ollila
@ 2017-03-25 15:07 ` David Bremner
1 sibling, 0 replies; 6+ messages in thread
From: David Bremner @ 2017-03-25 15:07 UTC (permalink / raw)
To: notmuch
David Bremner <david@tethera.net> writes:
> At least Fedora and Debian now use
> /usr/share/bash-completion/completions now. Apparently
> /etc/bash_completion.d will be phased out at some point in the future.
pushed to master.
d
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-25 15:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-04 11:09 bash completion install location David Bremner
2016-10-22 10:15 ` Jani Nikula
2016-10-22 10:59 ` Tomi Ollila
2017-03-12 17:24 ` [PATCH] configure: change default bash completion location to /usr/share David Bremner
2017-03-12 17:27 ` Tomi Ollila
2017-03-25 15:07 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).