From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>,
David Bremner <david@tethera.net>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] configure: change default bash completion location to /usr/share
Date: Sun, 12 Mar 2017 19:27:12 +0200 [thread overview]
Message-ID: <m2innetngv.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20170312172452.13444-1-david@tethera.net>
On Sun, Mar 12 2017, David Bremner <david@tethera.net> wrote:
> At least Fedora and Debian now use
> /usr/share/bash-completion/completions now. Apparently
> /etc/bash_completion.d will be phased out at some point in the future.
> ---
LGTM (from keyboard of 20+ year zsh user)
Tomi
> configure | 4 ++--
> debian/notmuch.install | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index e16a9b76..0de354ea 100755
> --- a/configure
> +++ b/configure
> @@ -132,7 +132,7 @@ Fine tuning of some installation directories is available:
> --sysconfdir=DIR Read-only single-machine data [PREFIX/etc]
> --emacslispdir=DIR Emacs code [PREFIX/share/emacs/site-lisp]
> --emacsetcdir=DIR Emacs miscellaneous files [PREFIX/share/emacs/site-lisp]
> - --bashcompletiondir=DIR Bash completions files [SYSCONFDIR/bash_completion.d]
> + --bashcompletiondir=DIR Bash completions files [PREFIX/share/bash-completion/completions]
> --zshcompletiondir=DIR Zsh completions files [PREFIX/share/zsh/functions/Completion/Unix]
>
> Some features can be disabled (--with-feature=no is equivalent to
> @@ -1030,7 +1030,7 @@ HAVE_DOXYGEN=${have_doxygen}
> desktop_dir = \$(prefix)/share/applications
>
> # The directory to which bash completions files should be installed
> -bash_completion_dir = ${BASHCOMPLETIONDIR:=\$(sysconfdir)/bash_completion.d}
> +bash_completion_dir = ${BASHCOMPLETIONDIR:=\$(prefix)/share/bash-completion/completions}
>
> # The directory to which zsh completions files should be installed
> zsh_completion_dir = ${ZSHCOMLETIONDIR:=\$(prefix)/share/zsh/functions/Completion/Unix}
> diff --git a/debian/notmuch.install b/debian/notmuch.install
> index 86e891d4..31b9a37e 100644
> --- a/debian/notmuch.install
> +++ b/debian/notmuch.install
> @@ -1,3 +1,3 @@
> usr/bin
> usr/share/man
> -etc/bash_completion.d
> +usr/share/bash-completion
> --
> 2.11.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2017-03-12 17:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 11:09 bash completion install location David Bremner
2016-10-22 10:15 ` Jani Nikula
2016-10-22 10:59 ` Tomi Ollila
2017-03-12 17:24 ` [PATCH] configure: change default bash completion location to /usr/share David Bremner
2017-03-12 17:27 ` Tomi Ollila [this message]
2017-03-25 15:07 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2innetngv.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).