[PATCH] test: allow disabling timeout with NOTMUCH_TEST_TIMEOUT=0

[PATCH] test: allow disabling timeout with NOTMUCH_TEST_TIMEOUT=0

[Daniel Kahn Gillmor]

Tests appear to be hanging when run under GNU timeout on debian
stretch.  To aid in diagnosing this or similar problems, it's handy to
be able to disable timeout from the command line at will.

Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
---
 test/notmuch-test | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/test/notmuch-test b/test/notmuch-test
index bbc2dc31..126c28d4 100755
--- a/test/notmuch-test
+++ b/test/notmuch-test
@@ -33,8 +33,13 @@ rm -rf $NOTMUCH_BUILDDIR/test/test-results
 # Test for timeout utility
 if command -v timeout >/dev/null; then
     TEST_TIMEOUT=${NOTMUCH_TEST_TIMEOUT:-2m}
-    TEST_TIMEOUT_CMD="timeout $TEST_TIMEOUT"
-    echo "INFO: using $TEST_TIMEOUT timeout for tests"
+    if [ "$TEST_TIMEOUT" = 0 ]; then
+        TEST_TIMEOUT_CMD=""
+        echo "INFO: timeout disabled"
+    else
+        TEST_TIMEOUT_CMD="timeout $TEST_TIMEOUT"
+        echo "INFO: using $TEST_TIMEOUT timeout for tests"
+    fi
 else
     TEST_TIMEOUT_CMD=""
 fi
-- 
2.20.1

Re: [PATCH] test: allow disabling timeout with NOTMUCH_TEST_TIMEOUT=0

[David Bremner]

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> Tests appear to be hanging when run under GNU timeout on debian
> stretch.  To aid in diagnosing this or similar problems, it's handy to
> be able to disable timeout from the command line at will.
>

1) Do we still need / want this?

2) care to reword the commit message?

d

Re: [PATCH] test: allow disabling timeout with NOTMUCH_TEST_TIMEOUT=0

[Daniel Kahn Gillmor]

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

On Wed 2019-05-22 08:52:55 -0300, David Bremner wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>
>> Tests appear to be hanging when run under GNU timeout on debian
>> stretch.  To aid in diagnosing this or similar problems, it's handy to
>> be able to disable timeout from the command line at will.
>>
>
> 1) Do we still need / want this?

Yes, i think it's useful if you want rule out coreutils when debugging
the test suite.

> 2) care to reword the commit message?

Sure, keeping the same subject line, i'd change the body to:



To aid in diagnosing test suite tooling that interacts poorly with
coreutils' timeout, it's handy to be able to bypass it entirely.





This isn't a high priority for me, but it's not a scary change either.

thanks for the review,

           --dkg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

Re: [PATCH] test: allow disabling timeout with NOTMUCH_TEST_TIMEOUT=0

[David Bremner]

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> On Wed 2019-05-22 08:52:55 -0300, David Bremner wrote:
>> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>>
>>> Tests appear to be hanging when run under GNU timeout on debian
>>> stretch.  To aid in diagnosing this or similar problems, it's handy to
>>> be able to disable timeout from the command line at will.
>>>
>>
>> 1) Do we still need / want this?
>
> Yes, i think it's useful if you want rule out coreutils when debugging
> the test suite.
>
>> 2) care to reword the commit message?
>
> Sure, keeping the same subject line, i'd change the body to:

Pushed,

d