unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: David Bremner <david@tethera.net>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] test: allow disabling timeout with NOTMUCH_TEST_TIMEOUT=0
Date: Fri, 24 May 2019 15:52:40 -0400	[thread overview]
Message-ID: <87h89j635j.fsf@fifthhorseman.net> (raw)
In-Reply-To: <878suyu2nc.fsf@tethera.net>

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

On Wed 2019-05-22 08:52:55 -0300, David Bremner wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>
>> Tests appear to be hanging when run under GNU timeout on debian
>> stretch.  To aid in diagnosing this or similar problems, it's handy to
>> be able to disable timeout from the command line at will.
>>
>
> 1) Do we still need / want this?

Yes, i think it's useful if you want rule out coreutils when debugging
the test suite.

> 2) care to reword the commit message?

Sure, keeping the same subject line, i'd change the body to:



To aid in diagnosing test suite tooling that interacts poorly with
coreutils' timeout, it's handy to be able to bypass it entirely.





This isn't a high priority for me, but it's not a scary change either.

thanks for the review,

           --dkg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2019-05-24 19:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20 23:25 [PATCH] test: allow disabling timeout with NOTMUCH_TEST_TIMEOUT=0 Daniel Kahn Gillmor
2019-05-22 11:52 ` David Bremner
2019-05-24 19:52   ` Daniel Kahn Gillmor [this message]
2019-05-25 11:32     ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h89j635j.fsf@fifthhorseman.net \
    --to=dkg@fifthhorseman.net \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).