From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qEv1OceB5WATwwAAgWs5BA (envelope-from ) for ; Wed, 07 Jul 2021 12:28:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id AOSQNceB5WBZBgAAbx9fmQ (envelope-from ) for ; Wed, 07 Jul 2021 10:28:23 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 768BA12DC7 for ; Wed, 7 Jul 2021 12:28:23 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 5D00F290D5; Wed, 7 Jul 2021 06:28:19 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 4CAE729058 for ; Wed, 7 Jul 2021 06:28:16 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id BC0775FD21; Wed, 7 Jul 2021 06:28:15 -0400 (EDT) Received: (nullmailer pid 107404 invoked by uid 1000); Wed, 07 Jul 2021 10:28:14 -0000 From: David Bremner To: Protesilaos Stavrou , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: use new face for notmuch-jump and related In-Reply-To: <87im1z43o9.fsf@protesilaos.com> References: <87lf6vxnw1.fsf@tethera.net> <87im1z43o9.fsf@protesilaos.com> Date: Wed, 07 Jul 2021 07:28:14 -0300 Message-ID: <874kd65sg1.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: VEEQATI227RDUCSHEFK5VR3GVVZBZRBM X-Message-ID-Hash: VEEQATI227RDUCSHEFK5VR3GVVZBZRBM X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625653703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=lOIJZIkBH9L1ls/jUz0S/cc7q0QfvvLaMrUujgPp4N8=; b=lotTe05u7uprXQRiXNe4PlWNSXRct8HghmuEiIbr5ODnWayIJOSJXN5heoJptw/8zDeMS6 GArl5jt+/7Vn3cChksX1A3KATaiQFyPMpiOqHjpPurX+F+fbDX5HkydY4sx7PZSXwXL50K 2ayymgXo45g89lz3lsHPy8b688EChYfvpHj88gMMkvcE1k2UHWBTM5P44SpbxnJAKS/D/6 wlGD6uaPGt/vrmwleD6MabFlBKZGm/KaPFXYtB4byFC6upgVdrv1aRw33mL9uT6AJmM+Yy GVo4updZ+MHwiQ7hsEPTUlLS7/PNBtUnvQGWOM07Cg87a7bBkmlcVWwOfzD6oQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625653703; a=rsa-sha256; cv=none; b=b55/4b8ZeQl6mqgeqxKdA0I6FDgyWg2QGQW9mL6gj6uhBmhaKfKuswtnVjuQrafCr3ep21 1wHCYGIooFX3Lm2//iud1poFo5UUAJ6Oy+wHbBosz8K1Vj8DRIOCP5A06EOK8Kx+OhEvKd ZMmMbB748HbG2hLEZbnXP94TkkMGseRamRN45dS75ZCatbHnQWGUfcl56oDeUY74ptscJP vAdVy1oLgyTtHYiyIIj0PMzMfTDYg5BSWhuH5cHuQZLFvTfyfthPj1md0fpmaMrKnONeUi 9SGYL7Vm3Gb9/BW6hC2VbB/aMP1V67aRpUdKgp/9BNhIoof3tsj2PIjeI1np6Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.04 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 768BA12DC7 X-Spam-Score: -2.04 X-Migadu-Scanner: scn0.migadu.com X-TUID: pFPBDrPkZvXV Protesilaos Stavrou writes: > On 2021-06-27, 13:39 -0300, David Bremner wrote: > >> Protesilaos Stavrou writes: >> >>> The use of a named face, notmuch-jump-key, makes it possible for users >>> or theme developers to apply properties that are specific to each of >>> those two cases. >>> >> >> applied to master, thanks > > You are welcome! I just noticed a mistake from my side. Please refer > to the attached patch. Shall I start a new thread of will this one > suffice? I guess you should start a new thread. Please use a more informative patch subject; you can mention the commit you are updating in the body of the commit message. I would avoid the word "amend" because that has a specific technical meaning in the context of git, and we're not going to rewrite published history. Thanks David