unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] emacs: do not change users' mail agent configuration
@ 2014-12-12 18:54 Łukasz Stelmach
  2014-12-13 21:04 ` Jani Nikula
  0 siblings, 1 reply; 7+ messages in thread
From: Łukasz Stelmach @ 2014-12-12 18:54 UTC (permalink / raw)
  To: notmuch; +Cc: Łukasz Stelmach

`mail-user-agent' is defined with defcustom and may be customised
by users. It should not be set to arbitrary values in modules.

To make use of that configuration value call `compose-mail' which
starts user's preferred mail composition package as selected with
the variable `mail-user-agent' instead of notmuch's hardcoded
`message-mail'.
---
 NEWS                 | 10 ++++++++++
 emacs/notmuch-mua.el |  2 +-
 emacs/notmuch.el     |  2 --
 3 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/NEWS b/NEWS
index 44e8d05..cf5b3c3 100644
--- a/NEWS
+++ b/NEWS
@@ -64,6 +64,16 @@ Added `notmuch address` subcommand
 Emacs Interface
 ---------------
 
+Fixed `mail-user-agent` handling
+
+  The value of the mail-user-agent variable is not forcibly set to
+  `notmuch-user-agent`, regardles of how a user has customised it,
+  everytime notmuch.el is loaded. This way, someone who used for example
+  Gnus has her MUA and notmuch just as a search engine, doesn't have her
+  configuration broken everytime notmuch.el is loaded. The user can now
+  use her favourite mail composing package when replying messages in
+  notmuch too.
+
 Use the `j` key to access saved searches from anywhere in notmuch
 
   `j` is now globally bound to `notmuch-jump`, which provides fast,
diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index 2c58886..f02c7b5 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -263,7 +263,7 @@ OTHER-ARGS are passed through to `message-mail'."
     (push (cons 'From (concat
 		       (notmuch-user-name) " <" (notmuch-user-primary-email) ">")) other-headers))
 
-  (apply #'message-mail to subject other-headers other-args)
+  (apply #'compose-mail to subject other-headers other-args)
   (message-sort-headers)
   (message-hide-headers)
   (set-buffer-modified-p nil)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 218486a..80cab57 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -1037,8 +1037,6 @@ notmuch buffers exist, run `notmuch'."
 	  (switch-to-buffer first))
       (notmuch))))
 
-(setq mail-user-agent 'notmuch-user-agent)
-
 (provide 'notmuch)
 
 ;; After provide to avoid loops if notmuch was require'd via notmuch-init-file.
-- 
2.0.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Importing notmuch should not change user configuration
@ 2017-08-23 12:07 Christoph Groth
  0 siblings, 0 replies; 7+ messages in thread
From: Christoph Groth @ 2017-08-23 12:07 UTC (permalink / raw)
  To: notmuch

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

Hello,

I’m using emacs notmuch together with Gnus and I noticed that M-x 
compose-mail stopped working properly for me since.  I identified 
notmuch as culprit: (requre ’notmuch) sets the user-customizable 
variable mail-user-agent.  I believe that such behavior is not 
expected of emacs modules.

A patch [1] has been proposed to fix this in 2014, but never 
accepted.  Is there a reason why the problematic behavior has been 
kept?

Thanks,
Christoph

[1] 
http://notmuch.198994.n3.nabble.com/PATCH-emacs-do-not-change-users-mail-agent-configuration-td4032745.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2017-08-23 13:40 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-12 18:54 [PATCH] emacs: do not change users' mail agent configuration Łukasz Stelmach
2014-12-13 21:04 ` Jani Nikula
2014-12-13 21:54   ` Lukasz Stelmach
2014-12-14  9:46     ` Jani Nikula
2014-12-14 23:49       ` Lukasz Stelmach
2017-08-23 13:40         ` Importing notmuch should not change user configuration David Bremner
  -- strict thread matches above, loose matches on Subject: below --
2017-08-23 12:07 Christoph Groth

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).