[PATCH] lib: fix uninitialized field in message objects.

[PATCH] lib: fix uninitialized field in message objects.

[David Bremner]

Initially reported by Eliza Vasquez [1] (via valgrind).

[1]: id:87o7zxj086.fsf@eliza.
---
 lib/message.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/message.cc b/lib/message.cc
index 63b216b6..bd3cb5af 100644
--- a/lib/message.cc
+++ b/lib/message.cc
@@ -169,6 +169,7 @@ _notmuch_message_create_for_document (const void *talloc_owner,
 
     message->doc = doc;
     message->termpos = 0;
+    message->modified = FALSE;
 
     return message;
 }
-- 
2.35.2

Re: [PATCH] lib: fix uninitialized field in message objects.

[David Bremner]

David Bremner <david@tethera.net> writes:

> Initially reported by Eliza Vasquez [1] (via valgrind).
>
> [1]: id:87o7zxj086.fsf@eliza.

Applied to release and master. As soon as I did realized that
pedantically it should be

             message->modified = false

since it's a bool, not a notmuch_bool_t. It's hard to imagine that
making a difference, but I guess we should clean that up eventually.

d

Re: [PATCH] lib: fix uninitialized field in message objects.

[David Bremner]

David Bremner <david@tethera.net> writes:

> David Bremner <david@tethera.net> writes:
>
>> Initially reported by Eliza Vasquez [1] (via valgrind).
>>
>> [1]: id:87o7zxj086.fsf@eliza.
>
> Applied to release and master. As soon as I did realized that
> pedantically it should be
>
>              message->modified = false
>
> since it's a bool, not a notmuch_bool_t. It's hard to imagine that
> making a difference, but I guess we should clean that up eventually.

And, eventually is now. I decided to just go and fix that. Apologies for
the extra noise.

d