unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] lib: fix uninitialized field in message objects.
@ 2022-05-25 10:56 David Bremner
  2022-05-26 11:26 ` David Bremner
  0 siblings, 1 reply; 3+ messages in thread
From: David Bremner @ 2022-05-25 10:56 UTC (permalink / raw)
  To: notmuch

Initially reported by Eliza Vasquez [1] (via valgrind).

[1]: id:87o7zxj086.fsf@eliza.
---
 lib/message.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/message.cc b/lib/message.cc
index 63b216b6..bd3cb5af 100644
--- a/lib/message.cc
+++ b/lib/message.cc
@@ -169,6 +169,7 @@ _notmuch_message_create_for_document (const void *talloc_owner,
 
     message->doc = doc;
     message->termpos = 0;
+    message->modified = FALSE;
 
     return message;
 }
-- 
2.35.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] lib: fix uninitialized field in message objects.
  2022-05-25 10:56 [PATCH] lib: fix uninitialized field in message objects David Bremner
@ 2022-05-26 11:26 ` David Bremner
  2022-05-26 11:38   ` David Bremner
  0 siblings, 1 reply; 3+ messages in thread
From: David Bremner @ 2022-05-26 11:26 UTC (permalink / raw)
  To: notmuch

David Bremner <david@tethera.net> writes:

> Initially reported by Eliza Vasquez [1] (via valgrind).
>
> [1]: id:87o7zxj086.fsf@eliza.

Applied to release and master. As soon as I did realized that
pedantically it should be

             message->modified = false

since it's a bool, not a notmuch_bool_t. It's hard to imagine that
making a difference, but I guess we should clean that up eventually.

d

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] lib: fix uninitialized field in message objects.
  2022-05-26 11:26 ` David Bremner
@ 2022-05-26 11:38   ` David Bremner
  0 siblings, 0 replies; 3+ messages in thread
From: David Bremner @ 2022-05-26 11:38 UTC (permalink / raw)
  To: notmuch

David Bremner <david@tethera.net> writes:

> David Bremner <david@tethera.net> writes:
>
>> Initially reported by Eliza Vasquez [1] (via valgrind).
>>
>> [1]: id:87o7zxj086.fsf@eliza.
>
> Applied to release and master. As soon as I did realized that
> pedantically it should be
>
>              message->modified = false
>
> since it's a bool, not a notmuch_bool_t. It's hard to imagine that
> making a difference, but I guess we should clean that up eventually.

And, eventually is now. I decided to just go and fix that. Apologies for
the extra noise.

d

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-05-26 11:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-25 10:56 [PATCH] lib: fix uninitialized field in message objects David Bremner
2022-05-26 11:26 ` David Bremner
2022-05-26 11:38   ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).