From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KMUfIPxjj2JcKgEAbAwnHQ (envelope-from ) for ; Thu, 26 May 2022 13:26:52 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id SOksH/xjj2IEfgEAG6o9tA (envelope-from ) for ; Thu, 26 May 2022 13:26:52 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4EEB3BCB5 for ; Thu, 26 May 2022 13:26:52 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 7CE5F5F782; Thu, 26 May 2022 11:26:49 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 6A1075F75B for ; Thu, 26 May 2022 11:26:46 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 0906A5FBD7; Thu, 26 May 2022 07:26:45 -0400 (EDT) Received: (nullmailer pid 306789 invoked by uid 1000); Thu, 26 May 2022 11:26:43 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: Re: [PATCH] lib: fix uninitialized field in message objects. In-Reply-To: <20220525105609.11215-1-david@tethera.net> References: <20220525105609.11215-1-david@tethera.net> Date: Thu, 26 May 2022 08:26:43 -0300 Message-ID: <87y1yo5ybw.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: F3HOO6OSZNJF4FOPZDL3PCSWLNTGBO6B X-Message-ID-Hash: F3HOO6OSZNJF4FOPZDL3PCSWLNTGBO6B X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653564412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=JuXJVNcpANtjwU87i2EYrgPtMKVAY7l6jz8GU8uq+LA=; b=WK7wUQDrIf7AfwuBRmDKJK3REQcmjwR7l4AXRHtExWGYMduv3Gj87Cmou/SkASCl0OMwCs B5gz/QLOeD7ql9z+7wMIY3eJevPjCTNhVomQJp90XS6UBH1m/jbtGWYro06VeoLTe5RJF4 Dw12hQo/jh/XiSStRhaQzHZm4QiV8h6LVaPxc304uvWBcuUITnClDQnokxraGnOeZ/MSWd uYPpXgJIw2q7tdqd9npLbJvRKKbdMzeSiYh5nRdbp0Pn2O+8Ic7/WsUKh+0gz9oG8MjDbB SoowG7x7BztorrotwNNgQzdXiymWJ4nLyowHoZ77ribzi3rvFx48vjub/W+HuQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653564412; a=rsa-sha256; cv=none; b=H+aQ09TTMONjofrWSYOCSAc1bzxZuvkgaF8RHuzJxf6J7G20Px1vZKxVV94j1DGTCFxIK9 4pee1ZwUsMRkaiokls00Y5tCY/Wbb76CGr0uaYjhbAUJwGQYXw0tOfzfR4snExME6sHlJL xmGpoczTjx3yABJa6gpzaJxUG+4QJDmWC0Mb8rZDLAMwIbn1fshHRg/iBObcyogzkiiiW8 BIITwwHJG4RIGxdbI6J4PaPWMaUD9N6Yb/epIA5Nlkz739I8gUH9XAyGDOE6Rdi1AenlVY YHujGaONfaJ7trDVHcinP+fxBBr+HwQTuQnQuPBebyKOI+0824bDPQ9I2KeWQg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.03 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 4EEB3BCB5 X-Spam-Score: -2.03 X-Migadu-Scanner: scn1.migadu.com X-TUID: +AqVn072pf0y David Bremner writes: > Initially reported by Eliza Vasquez [1] (via valgrind). > > [1]: id:87o7zxj086.fsf@eliza. Applied to release and master. As soon as I did realized that pedantically it should be message->modified = false since it's a bool, not a notmuch_bool_t. It's hard to imagine that making a difference, but I guess we should clean that up eventually. d