From: "W. Trevor King" <wking@tremily.us>
To: Mark Walters <markwalters1009@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons
Date: Mon, 3 Feb 2014 17:32:46 -0800 [thread overview]
Message-ID: <20140204013246.GQ19935@odin.tremily.us> (raw)
In-Reply-To: <20140203203418.GO14197@odin.tremily.us>
[-- Attachment #1: Type: text/plain, Size: 789 bytes --]
On Mon, Feb 03, 2014 at 12:34:18PM -0800, W. Trevor King wrote:
> On Mon, Feb 03, 2014 at 08:15:35PM +0000, Mark Walters wrote:
> > I think we should only display/use the content-description if it
> > exists and is non-empty.
>
> Sounds good to me. I'll queue this and a test for v2.
Rather than patching this in Emacs, maybe we should collapse the “not
set” and “set to empty string” cases in notmuch-show.c? I can't think
of any reasons why someone would want to distinguish those two cases,
and it's easier all around if we standardize the representation as far
upstream as possible.
Thoughts?
Trevor
--
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-04 1:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-02 20:46 [RFC] Content-Description when naming MIME parts in Emacs mode W. Trevor King
2014-02-02 23:33 ` David Bremner
2014-02-03 8:04 ` Mark Walters
2014-02-03 10:45 ` [PATCH 0/2] W. Trevor King
2014-02-03 10:45 ` [PATCH 1/2] notmuch-show: Add content-description output pair W. Trevor King
2014-02-03 10:45 ` [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons W. Trevor King
2014-02-03 20:15 ` Mark Walters
2014-02-03 20:34 ` W. Trevor King
2014-02-04 1:32 ` W. Trevor King [this message]
2014-02-08 12:55 ` David Bremner
2014-02-08 16:59 ` W. Trevor King
2014-02-09 10:10 ` Mark Walters
2014-02-09 12:53 ` David Bremner
2014-02-08 17:33 ` W. Trevor King
2014-02-09 10:17 ` Mark Walters
2014-02-03 20:44 ` Tomi Ollila
2014-02-04 0:14 ` W. Trevor King
2014-02-04 10:31 ` Tomi Ollila
2014-02-03 14:24 ` [PATCH 0/2] David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140204013246.GQ19935@odin.tremily.us \
--to=wking@tremily.us \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).