From: Mark Walters <markwalters1009@gmail.com>
To: "W. Trevor King" <wking@tremily.us>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons
Date: Sun, 09 Feb 2014 10:17:14 +0000 [thread overview]
Message-ID: <8761ood1zp.fsf@qmul.ac.uk> (raw)
In-Reply-To: <20140208173333.GC17142@odin.tremily.us>
On Sat, 08 Feb 2014, "W. Trevor King" <wking@tremily.us> wrote:
> On Mon, Feb 03, 2014 at 12:34:18PM -0800, W. Trevor King wrote:
>> On Mon, Feb 03, 2014 at 08:15:35PM +0000, Mark Walters wrote:
>> > My only other comment on the series is that you should update
>> > devel/schemata in the first patch to reflect this addition.
>>
>> Ah, I didn't realize that file existed :p.
>
> Looking at this more, I'm unsure about whether or not I should bump
> the version. b96ba63 (show: indicate length, encoding of omitted body
> content, 2012-12-16) added part.content-length? and
> part.content-transfer-encoding? and doesn't bump the version, while
> abeac48 (search: Add stable queries to thread search results,
> 2013-10-24) adds thread_summary.query and does bump the version. From
> notmuch-client.h:
>
> Backwards-incompatible changes such as removing map fields, changing
> the meaning of map fields, or changing the meanings of list elements
> should increase this. New (required) map fields can be added without
> increasing this.
>
> I think that the addition of part.content-description? should not bump
> the version, but then I'm not sure how to document the change in
> devel/schemata. I'm leaning towards something like:
I think you just add the new field to the list of fields in the schemata
in the appropriate place in the part section as
content-description?: string,
and you don't need to bump the version. I think this is because a client
can safely ask for this field regardless of the notmuch version and
won't get confused.
Best wishes
Mark
>
> diff --git a/devel/schemata b/devel/schemata
> index 41dc4a6..63d8aa4 100644
> --- a/devel/schemata
> +++ b/devel/schemata
> @@ -26,6 +26,9 @@ v1
> v2
> - Added the thread_summary.query field.
>
> +Staged for v3
> +- Added the part.content-descrition? field.
> +
> Common non-terminals
> --------------------
> …
>
> Alternatively, there could be a minor version that gets bumped on each
> tweak, however insignificant.
>
> Thoughts?
>
> Trevor
>
> --
> This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
> For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
next prev parent reply other threads:[~2014-02-09 10:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-02 20:46 [RFC] Content-Description when naming MIME parts in Emacs mode W. Trevor King
2014-02-02 23:33 ` David Bremner
2014-02-03 8:04 ` Mark Walters
2014-02-03 10:45 ` [PATCH 0/2] W. Trevor King
2014-02-03 10:45 ` [PATCH 1/2] notmuch-show: Add content-description output pair W. Trevor King
2014-02-03 10:45 ` [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons W. Trevor King
2014-02-03 20:15 ` Mark Walters
2014-02-03 20:34 ` W. Trevor King
2014-02-04 1:32 ` W. Trevor King
2014-02-08 12:55 ` David Bremner
2014-02-08 16:59 ` W. Trevor King
2014-02-09 10:10 ` Mark Walters
2014-02-09 12:53 ` David Bremner
2014-02-08 17:33 ` W. Trevor King
2014-02-09 10:17 ` Mark Walters [this message]
2014-02-03 20:44 ` Tomi Ollila
2014-02-04 0:14 ` W. Trevor King
2014-02-04 10:31 ` Tomi Ollila
2014-02-03 14:24 ` [PATCH 0/2] David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761ood1zp.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=wking@tremily.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).