From: Tomi Ollila <tomi.ollila@iki.fi>
To: "W. Trevor King" <wking@tremily.us>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons
Date: Tue, 04 Feb 2014 12:31:36 +0200 [thread overview]
Message-ID: <m2eh3jp3sn.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20140204001430.GP14197@odin.tremily.us>
On Tue, Feb 04 2014, "W. Trevor King" <wking@tremily.us> wrote:
> On Mon, Feb 03, 2014 at 10:44:39PM +0200, Tomi Ollila wrote:
>> having notmuch patch email as expected test output feels a bit
>> confusing to me -- especially as 'git grep' may catch some of the
>> (possibly future-outdated) content...
>
> There were two very similar patches with filename attachments in the
> corpus, so I used them for the tests ;). I can convert that test to
> use emacs_fcc_message or some other auto-generated content if you'd
> prefer.
You're right; corpus seems to be full of notmuch patch emails...
... and (although?) (just noticed)...
$ grep '^ *[+-].*\<if\>' test/* test/*/*
test/emacs.expected-output/attachment:+ if (pw_buf_size == -1)
pw_buf_size = 64;
test/emacs.expected-output/attachment:+ if (pw_buf_size == -1)
pw_buf_size = 64;
... I am not giving much resistance to keep the patch as it is :D
>
> Cheers,
> Trevor
>
Tomi
next prev parent reply other threads:[~2014-02-04 10:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-02 20:46 [RFC] Content-Description when naming MIME parts in Emacs mode W. Trevor King
2014-02-02 23:33 ` David Bremner
2014-02-03 8:04 ` Mark Walters
2014-02-03 10:45 ` [PATCH 0/2] W. Trevor King
2014-02-03 10:45 ` [PATCH 1/2] notmuch-show: Add content-description output pair W. Trevor King
2014-02-03 10:45 ` [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons W. Trevor King
2014-02-03 20:15 ` Mark Walters
2014-02-03 20:34 ` W. Trevor King
2014-02-04 1:32 ` W. Trevor King
2014-02-08 12:55 ` David Bremner
2014-02-08 16:59 ` W. Trevor King
2014-02-09 10:10 ` Mark Walters
2014-02-09 12:53 ` David Bremner
2014-02-08 17:33 ` W. Trevor King
2014-02-09 10:17 ` Mark Walters
2014-02-03 20:44 ` Tomi Ollila
2014-02-04 0:14 ` W. Trevor King
2014-02-04 10:31 ` Tomi Ollila [this message]
2014-02-03 14:24 ` [PATCH 0/2] David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2eh3jp3sn.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=notmuch@notmuchmail.org \
--cc=wking@tremily.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).