From: Michael J Gruber <git@grubix.eu>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] fix build failure with glib 2.67
Date: Mon, 15 Feb 2021 22:29:40 +0100 [thread overview]
Message-ID: <161342458057.194410.596832347560731148.git@grubix.eu> (raw)
In-Reply-To: <20210215205917.180301-1-david@tethera.net>
David Bremner venit, vidit, dixit 2021-02-15 21:59:17:
> Based on a patch from Michael J Gruber [1]. As of glib 2.67 (more
> specifically [2]), including "gmime-extra.h" inside an extern "C"
> block causes build failures, because glib is using C++ features.
>
> Observing that "gmime-extra.h" is no longer needed in
> notmuch-private.h, which can simply delete that include, but
> we have to correspondingly move the includes which might include
> it (in particular crypto.h) out of the extern "C" block also.
>
> This seems less fragile than only moving gmime-extra, and relying on
> preprocessor sentinels to keep the deeper includes from happening.
>
> Move to the include to the outside of the extern block.
>
> [1]: id:aee618a3d41f7889a7449aa16893e992325a909a.1613055071.git.git@grubix.eu
> [2]: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1715
> ---
>
> I neglected to change the author when amending. No fair blaming
> Michael for my potential mistakes
You never know before whether we share the fame or the blame :)
Anyway, the current patch is fully yours.
Cheers
Michael
prev parent reply other threads:[~2021-02-15 21:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 14:51 [PATCH] fix FTBFS with glib Michael J Gruber
2021-02-12 12:57 ` David Bremner
2021-02-12 15:01 ` Michael J Gruber
2021-02-12 18:48 ` Tomi Ollila
2021-02-12 19:51 ` Michael J Gruber
2021-02-13 21:22 ` [PATCH] fix build failure with glib 2.67 David Bremner
2021-02-15 20:59 ` David Bremner
2021-02-15 21:29 ` Michael J Gruber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161342458057.194410.596832347560731148.git@grubix.eu \
--to=git@grubix.eu \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).