Re: [PATCH] fix FTBFS with glib

[Tomi Ollila <tomi.ollila@iki.fi>]

On Thu, Feb 11 2021, Michael J. Gruber wrote:

> With newer glib, notmuch FTBFS because of C linkage error. This is due

If/when the alternative change is send (if it works), then it would be
nice if this FTBFS were opened (i searched it but deliberately leave
it still a mystery for some of us ;)

Tomi

> to a misplaced include (inside an extern "C") which was always there
> but exposed only recently through this change in glib:
>
> https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1715
>
> Move to the include to the outside of the extern block.
>
> Signed-off-by: Michael J Gruber <git@grubix.eu>
> ---
>  lib/notmuch-private.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h
> index 2fbf7ab9..46845253 100644
> --- a/lib/notmuch-private.h
> +++ b/lib/notmuch-private.h
> @@ -31,6 +31,8 @@
>  
>  #include "notmuch.h"
>  
> +#include "gmime-extra.h"
> +
>  NOTMUCH_BEGIN_DECLS
>  
>  #include <stdlib.h>
> @@ -47,8 +49,6 @@ NOTMUCH_BEGIN_DECLS
>  
>  #include <talloc.h>
>  
> -#include "gmime-extra.h"
> -
>  #include "xutil.h"
>  #include "error_util.h"
>  #include "string-util.h"
> -- 
> 2.30.0.368.g1c478ce6f6