From: David Bremner <david@tethera.net>
To: Michael J Gruber <git@grubix.eu>, notmuch@notmuchmail.org
Subject: Re: [PATCH] fix FTBFS with glib
Date: Fri, 12 Feb 2021 08:57:29 -0400 [thread overview]
Message-ID: <8735y1wiiu.fsf@tethera.net> (raw)
In-Reply-To: <aee618a3d41f7889a7449aa16893e992325a909a.1613055071.git.git@grubix.eu>
Michael J Gruber <git@grubix.eu> writes:
> With newer glib, notmuch FTBFS because of C linkage error. This is due
> to a misplaced include (inside an extern "C") which was always there
> but exposed only recently through this change in glib:
>
> https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1715
>
> Move to the include to the outside of the extern block.
Thanks for the patch. I have some questions / comments.
1) What version of glib are we talking about? Is it released yet?
2) The reason this works is that gmime-extra.h has its own extern
"C". If respinning the patch, it might be worth commenting on that.
3) I observed that just deleting #include "gmime-extra.h" from
notmuch-private.h works fine, presumably because it is included where it
is actually needed. In some sense this seems like a nicer solution. What
do you think?
d
next prev parent reply other threads:[~2021-02-12 12:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 14:51 [PATCH] fix FTBFS with glib Michael J Gruber
2021-02-12 12:57 ` David Bremner [this message]
2021-02-12 15:01 ` Michael J Gruber
2021-02-12 18:48 ` Tomi Ollila
2021-02-12 19:51 ` Michael J Gruber
2021-02-13 21:22 ` [PATCH] fix build failure with glib 2.67 David Bremner
2021-02-15 20:59 ` David Bremner
2021-02-15 21:29 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735y1wiiu.fsf@tethera.net \
--to=david@tethera.net \
--cc=git@grubix.eu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).