Re: [PATCH] fix FTBFS with glib

[Michael J Gruber <git@grubix.eu>]

David Bremner venit, vidit, dixit 2021-02-12 13:57:29:
> Michael J Gruber <git@grubix.eu> writes:
> 
> > With newer glib, notmuch FTBFS because of C linkage error. This is due
> > to a misplaced include (inside an extern "C") which was always there
> > but exposed only recently through this change in glib:
> >
> > https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1715
> >
> > Move to the include to the outside of the extern block.
> 
> Thanks for the patch. I have some questions / comments.
> 
> 1) What version of glib are we talking about? Is it released yet?

This showed up due to massive FTBFS on Fedora 34 (not released yet, but
branched for release).

glib 2.67.3 has the pertaining commit 51003d40.

> 2) The reason this works is that gmime-extra.h has its own extern
> "C". If respinning the patch, it might be worth commenting on that.

Yes. If you don't distinguish betwenn h/hpp then that is the way to go.

> 3) I observed that just deleting #include "gmime-extra.h" from
> notmuch-private.h works fine, presumably because it is included where it
> is actually needed. In some sense this seems like a nicer solution. What
> do you think?

Interesting. I assumed it's there for a reason. You introduced it in

cbb2d560 ("lib/cli: replace use of g_mime_message_get_sender", 2017-05-05)

so I guess you're the best person to ask whether it's till needed :)

Removing an unnecessary include would be the best solution, of course.

Cheers
Michael