* [bug#53859] [PATCH] gnu: clojure-data-xml: Fix build by removing tests.
@ 2022-02-07 19:32 Steve George
2022-02-07 19:32 ` [bug#53860] " Steve George
0 siblings, 1 reply; 4+ messages in thread
From: Steve George @ 2022-02-07 19:32 UTC (permalink / raw)
To: 53859
Hi,
New versions of clojure-tools are blocked by clojure-data-xml failing to
build. This is caused by the tests being out of date and not runnable
under recent JDKs [0]
The attached patch prevents all tests running, so the build runs. It
works, but doesn't seem optimal - though may be the best option until
upstream resolves?
Thanks,
Futurile
[0] https://ask.clojure.org/index.php/11546/clojure-data-xml-tests-fail-on-jdk-17 and https://clojure.atlassian.net/browse/DXML-67
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#53860] [PATCH] gnu: clojure-data-xml: Fix build by removing tests.
2022-02-07 19:32 [bug#53859] [PATCH] gnu: clojure-data-xml: Fix build by removing tests Steve George
@ 2022-02-07 19:32 ` Steve George
2022-02-08 10:55 ` bug#53860: " Julien Lepiller
2022-02-08 11:03 ` [bug#53860] (no subject) Steve George
0 siblings, 2 replies; 4+ messages in thread
From: Steve George @ 2022-02-07 19:32 UTC (permalink / raw)
To: 53860; +Cc: Steve George
* gnu/packages/clojure.scm (clojure-data-xml): tests don't work with stable and
recent versions of the JDK (https://clojure.atlassian.net/browse/DXML-67).
Prevent test build stage running.
---
gnu/packages/clojure.scm | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/clojure.scm b/gnu/packages/clojure.scm
index 40a3d7708a..6f9dbd6bca 100644
--- a/gnu/packages/clojure.scm
+++ b/gnu/packages/clojure.scm
@@ -333,10 +333,13 @@ is on par with Java implementations, e.g., Apache commons-codec.")
(arguments
'(#:source-dirs '("src/main/clojure")
#:test-dirs '("src/test/clojure")
- #:doc-dirs '()))
+ #:doc-dirs '()
+ ;; FIXME: resolve when https://clojure.atlassian.net/browse/DXML-67 is closed
+ #:tests? #f))
(propagated-inputs (list clojure-data-codec))
(synopsis "Clojure library for reading and writing XML data")
- (description "@code{data.xml} is a Clojure library for reading and writing
+ (description
+ "@code{data.xml} is a Clojure library for reading and writing
XML data. @code{data.xml} has the following features:
Parses XML documents into Clojure data structures
base-commit: abb197dfe98095a9ea7527a3ca3f81bb0edd5813
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#53860: [PATCH] gnu: clojure-data-xml: Fix build by removing tests.
2022-02-07 19:32 ` [bug#53860] " Steve George
@ 2022-02-08 10:55 ` Julien Lepiller
2022-02-08 11:03 ` [bug#53860] (no subject) Steve George
1 sibling, 0 replies; 4+ messages in thread
From: Julien Lepiller @ 2022-02-08 10:55 UTC (permalink / raw)
To: Steve George; +Cc: 53860-close
Le Mon, 7 Feb 2022 19:32:19 +0000,
Steve George <steve@futurile.net> a écrit :
> * gnu/packages/clojure.scm (clojure-data-xml): tests don't work with
> stable and recent versions of the JDK
> (https://clojure.atlassian.net/browse/DXML-67). Prevent test build
> stage running. ---
> gnu/packages/clojure.scm | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/clojure.scm b/gnu/packages/clojure.scm
> index 40a3d7708a..6f9dbd6bca 100644
> --- a/gnu/packages/clojure.scm
> +++ b/gnu/packages/clojure.scm
> @@ -333,10 +333,13 @@ is on par with Java implementations, e.g.,
> Apache commons-codec.") (arguments
> '(#:source-dirs '("src/main/clojure")
> #:test-dirs '("src/test/clojure")
> - #:doc-dirs '()))
> + #:doc-dirs '()
> + ;; FIXME: resolve when
> https://clojure.atlassian.net/browse/DXML-67 is closed
> + #:tests? #f))
> (propagated-inputs (list clojure-data-codec))
> (synopsis "Clojure library for reading and writing XML data")
> - (description "@code{data.xml} is a Clojure library for reading
> and writing
> + (description
> + "@code{data.xml} is a Clojure library for reading and writing
> XML data. @code{data.xml} has the following features:
>
> Parses XML documents into Clojure data structures
>
> base-commit: abb197dfe98095a9ea7527a3ca3f81bb0edd5813
Thanks for the patch! Ryan had a better approach in
https://issues.guix.gnu.org/53868, so I pushed it instead. Disabling
only the failing test is better that disabling all tests :).
Closing this as the package is now fixed. Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#53860] (no subject)
2022-02-07 19:32 ` [bug#53860] " Steve George
2022-02-08 10:55 ` bug#53860: " Julien Lepiller
@ 2022-02-08 11:03 ` Steve George
1 sibling, 0 replies; 4+ messages in thread
From: Steve George @ 2022-02-08 11:03 UTC (permalink / raw)
To: 53860
See #53868 which is better as it only stops cljs tests.
(https://debbugs.gnu.org/cgi/bugreport.cgi?bug=53868)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-08 12:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-07 19:32 [bug#53859] [PATCH] gnu: clojure-data-xml: Fix build by removing tests Steve George
2022-02-07 19:32 ` [bug#53860] " Steve George
2022-02-08 10:55 ` bug#53860: " Julien Lepiller
2022-02-08 11:03 ` [bug#53860] (no subject) Steve George
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.