From: Julien Lepiller <julien@lepiller.eu>
To: Steve George <steve@futurile.net>
Cc: 53860-close@debbugs.gnu.org
Subject: bug#53860: [PATCH] gnu: clojure-data-xml: Fix build by removing tests.
Date: Tue, 8 Feb 2022 11:55:49 +0100 [thread overview]
Message-ID: <20220208115549.71b1c7fa@tachikoma.lepiller.eu> (raw)
In-Reply-To: <20220207193219.4055890-2-steve@futurile.net>
Le Mon, 7 Feb 2022 19:32:19 +0000,
Steve George <steve@futurile.net> a écrit :
> * gnu/packages/clojure.scm (clojure-data-xml): tests don't work with
> stable and recent versions of the JDK
> (https://clojure.atlassian.net/browse/DXML-67). Prevent test build
> stage running. ---
> gnu/packages/clojure.scm | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/clojure.scm b/gnu/packages/clojure.scm
> index 40a3d7708a..6f9dbd6bca 100644
> --- a/gnu/packages/clojure.scm
> +++ b/gnu/packages/clojure.scm
> @@ -333,10 +333,13 @@ is on par with Java implementations, e.g.,
> Apache commons-codec.") (arguments
> '(#:source-dirs '("src/main/clojure")
> #:test-dirs '("src/test/clojure")
> - #:doc-dirs '()))
> + #:doc-dirs '()
> + ;; FIXME: resolve when
> https://clojure.atlassian.net/browse/DXML-67 is closed
> + #:tests? #f))
> (propagated-inputs (list clojure-data-codec))
> (synopsis "Clojure library for reading and writing XML data")
> - (description "@code{data.xml} is a Clojure library for reading
> and writing
> + (description
> + "@code{data.xml} is a Clojure library for reading and writing
> XML data. @code{data.xml} has the following features:
>
> Parses XML documents into Clojure data structures
>
> base-commit: abb197dfe98095a9ea7527a3ca3f81bb0edd5813
Thanks for the patch! Ryan had a better approach in
https://issues.guix.gnu.org/53868, so I pushed it instead. Disabling
only the failing test is better that disabling all tests :).
Closing this as the package is now fixed. Thanks!
next prev parent reply other threads:[~2022-02-08 11:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 19:32 [bug#53859] [PATCH] gnu: clojure-data-xml: Fix build by removing tests Steve George
2022-02-07 19:32 ` [bug#53860] " Steve George
2022-02-08 10:55 ` Julien Lepiller [this message]
2022-02-08 11:03 ` [bug#53860] (no subject) Steve George
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220208115549.71b1c7fa@tachikoma.lepiller.eu \
--to=julien@lepiller.eu \
--cc=53860-close@debbugs.gnu.org \
--cc=steve@futurile.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.