bug#46844: guile2.2-bytestructures fails to compile.

bug#46844: guile2.2-bytestructures fails to compile.

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

Hi Guix,

guile2.2-bytestructures and guile2.0-bytestructures don't compile.
The reason seems to be that v1.0.9 uses (scheme eval), which isn't
defined in guile2.0 and guile2.2. v1.0.8 doesn't use (scheme eval)

Here's the commit that seems to introduce the issue while fixing
another:

guix time-machine --commit=0a1da4652d9bb93d530ca52710f30b5d05a4251d -- build guile2.0-bytestructures guile2.2-bytestructures

According to a "guix refresh --list-dependent guile2.0-bytestructures guile2.2-bytestructures"
on 372b15f8625e7f20cafdba2677d4bf3f5eccc127, only "guile2.0-git",
"guile2.2-parted" and "guile2.2-guix" depend on these packages,
so unless someone needs "guile2.2-guix", it should be safe to remove
these packages.

Greetings,
Maxime.

(This issue prevents creating an environment for https://issues.guix.gnu.org/46826)


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

bug#46844: guile2.2-bytestructures fails to compile.

[Ludovic Courtès]

Hi,

Maxime Devos <maximedevos@telenet.be> skribis:

> guile2.2-bytestructures and guile2.0-bytestructures don't compile.
> The reason seems to be that v1.0.9 uses (scheme eval), which isn't
> defined in guile2.0 and guile2.2. v1.0.8 doesn't use (scheme eval)

Perhaps worth reporting upstream.

> Here's the commit that seems to introduce the issue while fixing
> another:
>
> guix time-machine --commit=0a1da4652d9bb93d530ca52710f30b5d05a4251d -- build guile2.0-bytestructures guile2.2-bytestructures
>
> According to a "guix refresh --list-dependent guile2.0-bytestructures guile2.2-bytestructures"
> on 372b15f8625e7f20cafdba2677d4bf3f5eccc127, only "guile2.0-git",
> "guile2.2-parted" and "guile2.2-guix" depend on these packages,
> so unless someone needs "guile2.2-guix", it should be safe to remove
> these packages.

‘guile2.2-guix’ exists mostly to check compatibility with 2.2.  I’d like
to drop 2.2 support soonish, though it’s okay to keep as long as it’s
not a burden (which it’s slowly becoming).

Thanks,
Ludo’.

bug#46844: guile2.2-bytestructures fails to compile.

[Taylan Kammer]

On 01.03.2021 09:06, Maxime Devos wrote:
> Hi Guix,
> 
> guile2.2-bytestructures and guile2.0-bytestructures don't compile.
> The reason seems to be that v1.0.9 uses (scheme eval), which isn't
> defined in guile2.0 and guile2.2. v1.0.8 doesn't use (scheme eval)
> 
> Here's the commit that seems to introduce the issue while fixing
> another:
> 
> guix time-machine --commit=0a1da4652d9bb93d530ca52710f30b5d05a4251d -- build guile2.0-bytestructures guile2.2-bytestructures
> 
> According to a "guix refresh --list-dependent guile2.0-bytestructures guile2.2-bytestructures"
> on 372b15f8625e7f20cafdba2677d4bf3f5eccc127, only "guile2.0-git",
> "guile2.2-parted" and "guile2.2-guix" depend on these packages,
> so unless someone needs "guile2.2-guix", it should be safe to remove
> these packages.
> 
> Greetings,
> Maxime.
> 
> (This issue prevents creating an environment for https://issues.guix.gnu.org/46826)
> 

Thanks for the report, I'm looking into it.

Actually 1.0.8 is the first version that uses '(scheme eval)' and 1.0.9
only makes a change to the environment argument passed to 'eval'.  I'm
assuming that the last working version was 1.0.7.

The reason '(scheme eval)' is needed is that I use the 'environment'
procedure to create an environment object to be passed as the second
argument to 'eval'.

I suppose I could instead use 'resolve-module' which should work across
2.x and 3.x.

I'll report as soon as I have an update.


- Taylan

bug#46844: guile2.2-bytestructures fails to compile.

[Taylan Kammer]

On 01.03.2021 15:47, Taylan Kammer wrote:
> I'll report as soon as I have an update.

I just released 1.0.10 which should work across Guile 2.0, 2.2, and 3.0.

I haven't yet updated the Guix package for bytestructures.  I'm quite
out of the loop and don't remember which branch that should be pushed,
given it's a dependency of Guix and all.  Is it always safe to push to
master?  (With regard to rebuilding the whole world.)

- Taylan

bug#46844: guile2.2-bytestructures fails to compile.

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 1177 bytes --]

On Wed, 2021-03-03 at 15:56 +0100, Taylan Kammer wrote:
> On 01.03.2021 15:47, Taylan Kammer wrote:
> [...]
> I haven't yet updated the Guix package for bytestructures.  I'm quite
> out of the loop and don't remember which branch that should be pushed,
> given it's a dependency of Guix and all.  Is it always safe to push to
> master?  (With regard to rebuilding the whole world.)

Let's see what would be rebuilt:

$ guix refresh --list-dependent guile-bytestructures guile2.0-bytestructures guile2.2-bytestructures

Building the following 15 packages would ensure 19 dependent packages are rebuilt: guile-wiredtiger@0.7.0 guile-libyaml@0-1.f5d33a6 
guile-parted@0.0.4 guix-data-service@0.0.1-25.b7ba8d0 guix-minimal@1.2.0-13.a53f711 cuirass@0.0.1-72.543e26a emacs-guix@0.5.2-3.a694fdb 
guix-jupyter@0.2.1 guix-build-coordinator@0-20.1f79fc3 gwl@0.3.0 hpcguix-web@0.0.1-5.9de6356 guix-daemon@1.2.0-13.a53f711 
guile2.0-git@0.4.0 guile2.2-parted@0.0.4 guile2.2-guix@1.2.0-13.a53f711

I suggest you run "./pre-inst-env guix build guix" first to make sure guix can still
be built, but otherwise there shouldn't be any issue with pushing to master.

Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

bug#46844: guile2.2-bytestructures fails to compile.

[Taylan Kammer]

I just pushed the update to guile-bytestructures 1.0.10 to Guix master,
and guile2.2-bytestructures builds for me.

- Taylan

bug#46844: guile2.2-bytestructures fails to compile.

[zimoun]

Hi,

On Wed, 10 Mar 2021 at 20:12, Taylan Kammer <taylan.kammer@gmail.com> wrote:

> I just pushed the update to guile-bytestructures 1.0.10 to Guix master,
> and guile2.2-bytestructures builds for me.

Just to say that the commit breaks "guix pull".


Cheers,
simon

bug#46844: guile2.2-bytestructures fails to compile.

[Taylan Kammer]

On 10.03.2021 21:12, zimoun wrote:
> Hi,
> 
> On Wed, 10 Mar 2021 at 20:12, Taylan Kammer <taylan.kammer@gmail.com> wrote:
> 
>> I just pushed the update to guile-bytestructures 1.0.10 to Guix master,
>> and guile2.2-bytestructures builds for me.
> 
> Just to say that the commit breaks "guix pull".

Ugh, sorry.  Looking into it now.


- Taylan

bug#46844: guile2.2-bytestructures fails to compile.

[Taylan Kammer]

On 10.03.2021 21:55, Taylan Kammer wrote:
> On 10.03.2021 21:12, zimoun wrote:
>> Hi,
>>
>> On Wed, 10 Mar 2021 at 20:12, Taylan Kammer <taylan.kammer@gmail.com> wrote:
>>
>>> I just pushed the update to guile-bytestructures 1.0.10 to Guix master,
>>> and guile2.2-bytestructures builds for me.
>>
>> Just to say that the commit breaks "guix pull".

Hmm, I can't seem to reproduce.  Guix pull finished successfully for
commit 6c5d358cc25ca94d9c0c75a3a086e81b2d63d1b6 (two commits after mine).

tkammer@debian:~/src/guix$ guix --version
guix (GNU Guix) 6c5d358cc25ca94d9c0c75a3a086e81b2d63d1b6
Copyright (C) 2021 the Guix authors
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

bug#46844: guile2.2-bytestructures fails to compile.

[zimoun]

Hi,

On Wed, 10 Mar 2021 at 22:11, Taylan Kammer <taylan.kammer@gmail.com> wrote:

> >>> I just pushed the update to guile-bytestructures 1.0.10 to Guix master,
> >>> and guile2.2-bytestructures builds for me.
> >>
> >> Just to say that the commit breaks "guix pull".
>
> Hmm, I can't seem to reproduce.  Guix pull finished successfully for
> commit 6c5d358cc25ca94d9c0c75a3a086e81b2d63d1b6 (two commits after mine).

No worry and all is explained there:

<https://lists.gnu.org/archive/html/guix-devel/2021-03/msg00156.html>

Cheers,
simon