From: Leo Prikler <leo.prikler@student.tugraz.at> To: Marius Bakke <mbakke@fastmail.com>, 39053-done@debbugs.gnu.org Cc: 38172-done@debbugs.gnu.org Subject: bug#38172: [bug#39053] [PATCH] Add pulseaudio configuration and fix volume bugs Date: Sat, 11 Jan 2020 19:37:54 +0100 [thread overview] Message-ID: <d17731158ca344803f624bc6c08e5490065f9c40.camel@student.tugraz.at> (raw) In-Reply-To: <87ftglzz3l.fsf@devup.no> Am Samstag, den 11.01.2020, 18:23 +0100 schrieb Marius Bakke: > Leo Prikler <leo.prikler@student.tugraz.at> writes: > > > This series of patches adds a configuration type for pulseaudio and > > also fixes > > a bug, where various applications would inadvertently max out the > > system volume > > (see e.g. #38172). > > Thanks! I've pushed the patches with mentioned tweaks in > 2c7511fb6..71e33e32f. Thanks! Also, I'm sorry about accidentally opening like 10 bugs due to my misconfiguration there. I only noticed after the fact, that merely CC'ing the original bug does nothing, when the mail is still sent to guix-patches as well. I've learned my lesson and will be more careful in the future. I do still have some open questions, though. > > +In addition to the above, @code{default-script-file} will be set to > > the > > +value of @code{script-file}. By default, @var{flat-volumes} is > > set > > to > > +``no'', so as to avoid bugs related to this feature. > > > The first sentence of this paragraph is obsolete, no? The second is > rather vague, so I opted to remove the whole thing. Let me know if > you > think something should be added! I'm not quite sure about the first sentence. While everyone can read the code and the output files produced from it, I think we should document, that we actually always insert this line into @file{daemon.conf}. For instance, if you don't supply your own @file{default.pa}, the first line of @file{daemon.conf} will be --8<---------------cut here---------------start------------->8--- default-script-file = /gnu/store/<hash>-pulseaudio- <version>/etc/pulse/default.pa --8<---------------cut here---------------end--------------->8--- What are your thoughts on this? > I added a (default: ...) on these two and removed the related > sentences. I was hesitant to do that due to the line limits. Do those not count for documentation or are such exceptions allowed? Thanks again for your help and also thanks for your feedback. Regards, Leo
WARNING: multiple messages have this Message-ID (diff)
From: Leo Prikler <leo.prikler@student.tugraz.at> To: Marius Bakke <mbakke@fastmail.com>, 39053-done@debbugs.gnu.org Cc: 38172-done@debbugs.gnu.org Subject: [bug#39053] [PATCH] Add pulseaudio configuration and fix volume bugs Date: Sat, 11 Jan 2020 19:37:54 +0100 [thread overview] Message-ID: <d17731158ca344803f624bc6c08e5490065f9c40.camel@student.tugraz.at> (raw) In-Reply-To: <87ftglzz3l.fsf@devup.no> Am Samstag, den 11.01.2020, 18:23 +0100 schrieb Marius Bakke: > Leo Prikler <leo.prikler@student.tugraz.at> writes: > > > This series of patches adds a configuration type for pulseaudio and > > also fixes > > a bug, where various applications would inadvertently max out the > > system volume > > (see e.g. #38172). > > Thanks! I've pushed the patches with mentioned tweaks in > 2c7511fb6..71e33e32f. Thanks! Also, I'm sorry about accidentally opening like 10 bugs due to my misconfiguration there. I only noticed after the fact, that merely CC'ing the original bug does nothing, when the mail is still sent to guix-patches as well. I've learned my lesson and will be more careful in the future. I do still have some open questions, though. > > +In addition to the above, @code{default-script-file} will be set to > > the > > +value of @code{script-file}. By default, @var{flat-volumes} is > > set > > to > > +``no'', so as to avoid bugs related to this feature. > > > The first sentence of this paragraph is obsolete, no? The second is > rather vague, so I opted to remove the whole thing. Let me know if > you > think something should be added! I'm not quite sure about the first sentence. While everyone can read the code and the output files produced from it, I think we should document, that we actually always insert this line into @file{daemon.conf}. For instance, if you don't supply your own @file{default.pa}, the first line of @file{daemon.conf} will be --8<---------------cut here---------------start------------->8--- default-script-file = /gnu/store/<hash>-pulseaudio- <version>/etc/pulse/default.pa --8<---------------cut here---------------end--------------->8--- What are your thoughts on this? > I added a (default: ...) on these two and removed the related > sentences. I was hesitant to do that due to the line limits. Do those not count for documentation or are such exceptions allowed? Thanks again for your help and also thanks for your feedback. Regards, Leo
next prev parent reply other threads:[~2020-01-11 18:38 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-09 13:57 [bug#39053] [PATCH] Add pulseaudio configuration and fix volume bugs Leo Prikler 2020-01-09 13:57 ` [bug#39052] [PATCH 1/3] services: Add pulseaudio-configuration Leo Prikler 2020-01-09 13:57 ` [bug#39054] [PATCH 2/3] services: pulseaudio-service-type: Honor /etc Leo Prikler 2020-01-09 13:57 ` [bug#39055] [PATCH 3/3] services: Add pulseaudio to %desktop-services Leo Prikler 2020-01-09 21:50 ` [bug#39053] [PATCH] Add pulseaudio configuration and fix volume bugs Marius Bakke 2020-01-10 1:48 ` [bug#39062] [PATCH 1/6] services: Add pulseaudio-configuration Leo Prikler 2020-01-10 1:48 ` [bug#39061] [PATCH 2/6] services: pulseaudio-service-type: Honor /etc Leo Prikler 2020-01-11 16:57 ` Marius Bakke 2020-01-10 1:48 ` [bug#39053] [PATCH 3/6] services: pulseaudio-configuration: Set flat-volumes to no Leo Prikler 2020-01-11 16:59 ` [bug#39053] [bug#39063] " Marius Bakke 2020-01-10 1:48 ` [bug#39065] [PATCH 4/6] services: Split ladspa-service-type from pulseaudio-service-type Leo Prikler 2020-01-11 17:00 ` [bug#39053] " Marius Bakke 2020-01-10 1:48 ` [bug#39053] [PATCH 5/6] doc: Add pulseaudio documentation Leo Prikler 2020-01-11 17:09 ` [bug#39064] " Marius Bakke 2020-01-11 17:25 ` [bug#39053] " Marius Bakke 2020-01-10 1:48 ` [bug#39066] [PATCH 6/6] services: Add pulseaudio to %desktop-services Leo Prikler 2020-01-11 17:10 ` [bug#39053] " Marius Bakke 2020-01-17 16:30 ` [bug#39053] [bug#39066] " Ludovic Courtès 2020-01-11 17:23 ` bug#38172: [bug#39053] [PATCH] Add pulseaudio configuration and fix volume bugs Marius Bakke 2020-01-11 18:37 ` Leo Prikler [this message] 2020-01-11 18:37 ` Leo Prikler 2020-01-11 23:49 ` Marius Bakke 2020-01-12 0:32 ` Leo Prikler 2020-01-12 19:55 ` Marius Bakke 2020-01-12 20:22 ` Leo Prikler
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d17731158ca344803f624bc6c08e5490065f9c40.camel@student.tugraz.at \ --to=leo.prikler@student.tugraz.at \ --cc=38172-done@debbugs.gnu.org \ --cc=39053-done@debbugs.gnu.org \ --cc=mbakke@fastmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/guix.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.