From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Prikler Subject: bug#38172: [bug#39053] [PATCH] Add pulseaudio configuration and fix volume bugs Date: Sat, 11 Jan 2020 19:37:54 +0100 Message-ID: References: <20200109135746.1993-1-leo.prikler@student.tugraz.at> <87ftglzz3l.fsf@devup.no> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:45168) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iqLe7-0006hY-VE for bug-guix@gnu.org; Sat, 11 Jan 2020 13:38:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iqLe6-0006VG-QL for bug-guix@gnu.org; Sat, 11 Jan 2020 13:38:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50703) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iqLe6-0006Tv-BL for bug-guix@gnu.org; Sat, 11 Jan 2020 13:38:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iqLe6-0007Tp-AC for bug-guix@gnu.org; Sat, 11 Jan 2020 13:38:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87ftglzz3l.fsf@devup.no> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org Sender: "bug-Guix" To: Marius Bakke , 39053-done@debbugs.gnu.org Cc: 38172-done@debbugs.gnu.org Am Samstag, den 11.01.2020, 18:23 +0100 schrieb Marius Bakke: > Leo Prikler writes: > > > This series of patches adds a configuration type for pulseaudio and > > also fixes > > a bug, where various applications would inadvertently max out the > > system volume > > (see e.g. #38172). > > Thanks! I've pushed the patches with mentioned tweaks in > 2c7511fb6..71e33e32f. Thanks! Also, I'm sorry about accidentally opening like 10 bugs due to my misconfiguration there. I only noticed after the fact, that merely CC'ing the original bug does nothing, when the mail is still sent to guix-patches as well. I've learned my lesson and will be more careful in the future. I do still have some open questions, though. > > +In addition to the above, @code{default-script-file} will be set to > > the > > +value of @code{script-file}. By default, @var{flat-volumes} is > > set > > to > > +``no'', so as to avoid bugs related to this feature. > > > The first sentence of this paragraph is obsolete, no? The second is > rather vague, so I opted to remove the whole thing. Let me know if > you > think something should be added! I'm not quite sure about the first sentence. While everyone can read the code and the output files produced from it, I think we should document, that we actually always insert this line into @file{daemon.conf}. For instance, if you don't supply your own @file{default.pa}, the first line of @file{daemon.conf} will be --8<---------------cut here---------------start------------->8--- default-script-file = /gnu/store/-pulseaudio- /etc/pulse/default.pa --8<---------------cut here---------------end--------------->8--- What are your thoughts on this? > I added a (default: ...) on these two and removed the related > sentences. I was hesitant to do that due to the line limits. Do those not count for documentation or are such exceptions allowed? Thanks again for your help and also thanks for your feedback. Regards, Leo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:45184) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iqLe8-0006iB-6F for guix-patches@gnu.org; Sat, 11 Jan 2020 13:38:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iqLe6-0006VP-R3 for guix-patches@gnu.org; Sat, 11 Jan 2020 13:38:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50704) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iqLe6-0006V5-Nr for guix-patches@gnu.org; Sat, 11 Jan 2020 13:38:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iqLe6-0007Tw-Mk for guix-patches@gnu.org; Sat, 11 Jan 2020 13:38:02 -0500 Subject: [bug#39053] [PATCH] Add pulseaudio configuration and fix volume bugs Resent-Message-ID: Message-ID: From: Leo Prikler Date: Sat, 11 Jan 2020 19:37:54 +0100 In-Reply-To: <87ftglzz3l.fsf@devup.no> References: <20200109135746.1993-1-leo.prikler@student.tugraz.at> <87ftglzz3l.fsf@devup.no> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke , 39053-done@debbugs.gnu.org Cc: 38172-done@debbugs.gnu.org Am Samstag, den 11.01.2020, 18:23 +0100 schrieb Marius Bakke: > Leo Prikler writes: > > > This series of patches adds a configuration type for pulseaudio and > > also fixes > > a bug, where various applications would inadvertently max out the > > system volume > > (see e.g. #38172). > > Thanks! I've pushed the patches with mentioned tweaks in > 2c7511fb6..71e33e32f. Thanks! Also, I'm sorry about accidentally opening like 10 bugs due to my misconfiguration there. I only noticed after the fact, that merely CC'ing the original bug does nothing, when the mail is still sent to guix-patches as well. I've learned my lesson and will be more careful in the future. I do still have some open questions, though. > > +In addition to the above, @code{default-script-file} will be set to > > the > > +value of @code{script-file}. By default, @var{flat-volumes} is > > set > > to > > +``no'', so as to avoid bugs related to this feature. > > > The first sentence of this paragraph is obsolete, no? The second is > rather vague, so I opted to remove the whole thing. Let me know if > you > think something should be added! I'm not quite sure about the first sentence. While everyone can read the code and the output files produced from it, I think we should document, that we actually always insert this line into @file{daemon.conf}. For instance, if you don't supply your own @file{default.pa}, the first line of @file{daemon.conf} will be --8<---------------cut here---------------start------------->8--- default-script-file = /gnu/store/-pulseaudio- /etc/pulse/default.pa --8<---------------cut here---------------end--------------->8--- What are your thoughts on this? > I added a (default: ...) on these two and removed the related > sentences. I was hesitant to do that due to the line limits. Do those not count for documentation or are such exceptions allowed? Thanks again for your help and also thanks for your feedback. Regards, Leo