[bug#66597] [PATCH] gnu: Add sdl2-gamecontrollerdb.

[bug#66597] [PATCH] gnu: Add sdl2-gamecontrollerdb.

[Liliana Marie Prikler]

Once more for the mailing list…

Am Dienstag, dem 17.10.2023 um 19:10 +0300 schrieb Evgeny Pisemsky:
> * gnu/packages/game-development.scm (sdl2-gamecontrollerdb): New
> variable.
> ---
>  gnu/packages/game-development.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-
> developm=
> ent.scm
> index eb1d74d1e1..3400ca03dc 100644
> --- a/gnu/packages/game-development.scm
> +++ b/gnu/packages/game-development.scm
> @@ -29,6 +29,7 @@
>  ;;; Copyright =C2=A9 2022 Jai Vetrivelan <jaivetrivelan@gmail.com>
>  ;;; Copyright =C2=A9 2022 dan <i@dan.games>
>  ;;; Copyright =C2=A9 2023 John Kehayias
> <john.kehayias@protonmail.com>
> +;;; Copyright =C2=A9 2023 Evgeny Pisemsky <evgeny@pisemsky.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -56,6 +57,7 @@ (define-module (gnu packages game-development)
>    #:use-module (guix svn-download)
>    #:use-module (guix utils)
>    #:use-module (guix build-system cmake)
> +  #:use-module (guix build-system copy)
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system python)
>    #:use-module (guix build-system scons)
> @@ -3283,3 +3285,29 @@ (define-public bbcsdl
>  allowing you to write utilities and games, use sound and graphics,
> perform
>  calculations and create complete applications.")
>      (license license:zlib)))
This appears to be at the end of the file.  We typically prefer
somewhere in the middle (makes it harder to break the diffs),
especially if there's a topical fit.
> +
> +(define-public sdl2-gamecontrollerdb
> +  (let ((commit "6f3c4edcb5a2e2ed090ca8af40d2c0f00dcd77f6")
> +        (revision "0"))
> +    (package
> +      (name "sdl2-gamecontrollerdb")
> +      (version (git-version "0" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url
> "https://github.com/gabomdq/SDL_GameControllerDB")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32
> "1gciqc8qm2qgcjj5s9jpclznznsp6awl4ldrnj7g01chkcx0l6a3"))=
> ))
> +      (build-system copy-build-system)
> +      (arguments
> +       '(#:install-plan '(("gamecontrollerdb.txt"
> +                           "share/sdl2-gamecontrollerdb/"))))
Is this destination documented somewhere?  Or should we just do
"/share/sdl2/" instead?
> +      (home-page "https://github.com/gabomdq/SDL_GameControllerDB")
> +      (synopsis "SDL2 game controller database")
> +      (description
> +       "A community sourced database of game controller mappings to
> be used
> +with SDL2 Game Controller functionality.")
The description a full sentence.  Often, we simply cheat with "this
package provides…"
> +      (license license:zlib))))
> 
> base-commit: 018567adb7b2d31d0bd457983b755ec3063d08c6
> --=20
> 2.41.0
Cheers

[bug#66597] [PATCH] gnu: Add sdl2-gamecontrollerdb.

[Evgeny Pisemsky]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

Hello!

The share path is not documented anywhere, I just used a package name to construct it.

There is no standard path where this database is expected to be, it must be specified.

I updated the patch with your recommendations and moved the package to the sdl module.


[-- Attachment #2: 0001-gnu-Add-sdl2-gamecontrollerdb.patch --]
[-- Type: text/x-patch, Size: 2494 bytes --]

From 50a639bda381fadd41ed7ba0656cc4d09adb3c9c Mon Sep 17 00:00:00 2001
From: Evgeny Pisemsky <evgeny@pisemsky.com>
Date: Fri, 20 Oct 2023 23:23:23 +0300
Subject: [PATCH] gnu: Add sdl2-gamecontrollerdb.

* gnu/packages/sdl.scm (sdl2-gamecontrollerdb): New variable.
---
 gnu/packages/sdl.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/sdl.scm b/gnu/packages/sdl.scm
index 11aa5e1602..79f0bd7c08 100644
--- a/gnu/packages/sdl.scm
+++ b/gnu/packages/sdl.scm
@@ -14,6 +14,7 @@
 ;;; Copyright © 2020 Timotej Lazar <timotej.lazar@araneo.si>
 ;;; Copyright © 2020 Oleg Pykhalov <go.wigust@gmail.com>
 ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
+;;; Copyright © 2023 Evgeny Pisemsky <evgeny@pisemsky.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -41,6 +42,7 @@ (define-module (gnu packages sdl)
   #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module (guix utils)
+  #:use-module (guix build-system copy)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system trivial)
   #:use-module (gnu packages audio)
@@ -563,6 +565,31 @@ (define-public sdl2-ttf
        (prepend harfbuzz freetype)))
     (properties '((upstream-name . "SDL2_ttf")))))
 
+(define-public sdl2-gamecontrollerdb
+  (let ((commit "6f3c4edcb5a2e2ed090ca8af40d2c0f00dcd77f6")
+        (revision "0"))
+    (package
+      (name "sdl2-gamecontrollerdb")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/gabomdq/SDL_GameControllerDB")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1gciqc8qm2qgcjj5s9jpclznznsp6awl4ldrnj7g01chkcx0l6a3"))))
+      (build-system copy-build-system)
+      (arguments
+       '(#:install-plan '(("gamecontrollerdb.txt" "share/sdl2/"))))
+      (home-page "https://github.com/gabomdq/SDL_GameControllerDB")
+      (synopsis "SDL2 game controller database")
+      (description
+       "This package provides a community sourced database of game controller
+mappings.  They supposed to be used with SDL2 Game Controller functionality.")
+      (license license:zlib))))
+
 (define-public guile-sdl
   (package
     (name "guile-sdl")

base-commit: b3d0797d279b0aa48f6b652c149b7f974f3acc89
-- 
2.41.0

[bug#66597] [PATCH] gnu: Add sdl2-gamecontrollerdb.

[Liliana Marie Prikler]

Am Samstag, dem 21.10.2023 um 01:45 +0300 schrieb Evgeny Pisemsky:

> +       "This package provides a community sourced database of game
> controller
> +mappings.  They supposed to be used with SDL2 Game Controller
> functionality.")
I've reworded this description locally to be grammatically correct and
also a bit snappier (the last one's my personal interpretation).

Otherwise LGTM so far.  Will build locally for testing purposes and
likely push next weekend.

Cheers

bug#66597: [PATCH] gnu: Add sdl2-gamecontrollerdb.

[Liliana Marie Prikler]

Am Samstag, dem 21.10.2023 um 22:05 +0200 schrieb Liliana Marie
Prikler:
> Am Samstag, dem 21.10.2023 um 01:45 +0300 schrieb Evgeny Pisemsky:
> 
> > +       "This package provides a community sourced database of game
> > controller
> > +mappings.  They supposed to be used with SDL2 Game Controller
> > functionality.")
> I've reworded this description locally to be grammatically correct
> and also a bit snappier (the last one's my personal interpretation).
> 
> Otherwise LGTM so far.  Will build locally for testing purposes and
> likely push next weekend.
Pushed now.

Cheers