From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Evgeny Pisemsky <evgeny@pisemsky.com>
Cc: 66597@debbugs.gnu.org
Subject: [bug#66597] [PATCH] gnu: Add sdl2-gamecontrollerdb.
Date: Tue, 17 Oct 2023 22:04:16 +0200 [thread overview]
Message-ID: <71339937b94534858a8c4faf638b03f63424b05e.camel@gmail.com> (raw)
In-Reply-To: <dc4622a59b80bafe2790fd8f0ec354e56235f868.camel@pisemsky.com>
Once more for the mailing list…
Am Dienstag, dem 17.10.2023 um 19:10 +0300 schrieb Evgeny Pisemsky:
> * gnu/packages/game-development.scm (sdl2-gamecontrollerdb): New
> variable.
> ---
> gnu/packages/game-development.scm | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-
> developm=
> ent.scm
> index eb1d74d1e1..3400ca03dc 100644
> --- a/gnu/packages/game-development.scm
> +++ b/gnu/packages/game-development.scm
> @@ -29,6 +29,7 @@
> ;;; Copyright =C2=A9 2022 Jai Vetrivelan <jaivetrivelan@gmail.com>
> ;;; Copyright =C2=A9 2022 dan <i@dan.games>
> ;;; Copyright =C2=A9 2023 John Kehayias
> <john.kehayias@protonmail.com>
> +;;; Copyright =C2=A9 2023 Evgeny Pisemsky <evgeny@pisemsky.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -56,6 +57,7 @@ (define-module (gnu packages game-development)
> #:use-module (guix svn-download)
> #:use-module (guix utils)
> #:use-module (guix build-system cmake)
> + #:use-module (guix build-system copy)
> #:use-module (guix build-system gnu)
> #:use-module (guix build-system python)
> #:use-module (guix build-system scons)
> @@ -3283,3 +3285,29 @@ (define-public bbcsdl
> allowing you to write utilities and games, use sound and graphics,
> perform
> calculations and create complete applications.")
> (license license:zlib)))
This appears to be at the end of the file. We typically prefer
somewhere in the middle (makes it harder to break the diffs),
especially if there's a topical fit.
> +
> +(define-public sdl2-gamecontrollerdb
> + (let ((commit "6f3c4edcb5a2e2ed090ca8af40d2c0f00dcd77f6")
> + (revision "0"))
> + (package
> + (name "sdl2-gamecontrollerdb")
> + (version (git-version "0" revision commit))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url
> "https://github.com/gabomdq/SDL_GameControllerDB")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> "1gciqc8qm2qgcjj5s9jpclznznsp6awl4ldrnj7g01chkcx0l6a3"))=
> ))
> + (build-system copy-build-system)
> + (arguments
> + '(#:install-plan '(("gamecontrollerdb.txt"
> + "share/sdl2-gamecontrollerdb/"))))
Is this destination documented somewhere? Or should we just do
"/share/sdl2/" instead?
> + (home-page "https://github.com/gabomdq/SDL_GameControllerDB")
> + (synopsis "SDL2 game controller database")
> + (description
> + "A community sourced database of game controller mappings to
> be used
> +with SDL2 Game Controller functionality.")
The description a full sentence. Often, we simply cheat with "this
package provides…"
> + (license license:zlib))))
>
> base-commit: 018567adb7b2d31d0bd457983b755ec3063d08c6
> --=20
> 2.41.0
Cheers
next parent reply other threads:[~2023-10-17 20:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <dc4622a59b80bafe2790fd8f0ec354e56235f868.camel@pisemsky.com>
2023-10-17 20:04 ` Liliana Marie Prikler [this message]
2023-10-20 22:45 ` [bug#66597] [PATCH] gnu: Add sdl2-gamecontrollerdb Evgeny Pisemsky
2023-10-21 20:05 ` Liliana Marie Prikler
2023-10-27 14:35 ` bug#66597: " Liliana Marie Prikler
2023-10-17 18:19 [bug#66597] " Evgeny Pisemsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71339937b94534858a8c4faf638b03f63424b05e.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=66597@debbugs.gnu.org \
--cc=evgeny@pisemsky.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.