From: "Leo Famulari" <leo@famulari.name>
To: "Marius Bakke" <marius@gnu.org>, "Ludovic Courtès" <ludo@gnu.org>
Cc: 53295-done@debbugs.gnu.org
Subject: [bug#53295] [PATCH] gnu: Add FFmpeg 5.0.
Date: Mon, 23 May 2022 21:03:20 -0400 [thread overview]
Message-ID: <c15990da-0896-45f6-80df-1d019f1cd540@www.fastmail.com> (raw)
In-Reply-To: <87h75g2krt.fsf@gnu.org>
Thank you Marius! I've been distracted and busy offline so I very much appreciate you finishing this work!
On Mon, May 23, 2022, at 13:58, Marius Bakke wrote:
> Ludovic Courtès <ludo@gnu.org> skriver:
>
>> Hi,
>>
>> Leo Famulari <leo@famulari.name> skribis:
>>
>>> Here's the new major release of FFmpeg.
>>>
>>> We can add it right away and move users over to it incrementally as we
>>> test them — having this new version is useful for people like me who use
>>> FFmpeg directly.
>>>
>>> Also, I always found our FFmpeg packages' use of inheritance to be
>>> confusing when making changes to them, so I didn't use it here.
>>>
>>> * gnu/packages/video.scm (ffmpeg-5): New variable.
>>
>> Could you remove input labels? (I think ‘guix style’ can’t help because
>> of the conditional in the middle.)
>>
>> That said, it seems to me there’s a lot of duplication here compared to
>> version 4. So I’d be in favor of inheriting from that one.
>
> I went ahead and pushed this patch in 1cb10f696813ef23678029, with the
> adjustments Ludo recommended + G-expressions; as well as a follow-up
> that makes ffmpeg@4 inherit from it.
>
> Thanks Leo & Ludo!
>
> Attachments:
> * signature.asc
prev parent reply other threads:[~2022-05-24 1:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-16 5:35 [bug#53295] [PATCH] gnu: Add FFmpeg 5.0 Leo Famulari
2022-01-24 9:24 ` Ludovic Courtès
2022-05-23 17:58 ` bug#53295: " Marius Bakke
2022-05-24 1:03 ` Leo Famulari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c15990da-0896-45f6-80df-1d019f1cd540@www.fastmail.com \
--to=leo@famulari.name \
--cc=53295-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=marius@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.