From: "Ludovic Courtès" <ludo@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: 53295@debbugs.gnu.org
Subject: [bug#53295] [PATCH] gnu: Add FFmpeg 5.0.
Date: Mon, 24 Jan 2022 10:24:06 +0100 [thread overview]
Message-ID: <87pmohwkp5.fsf@gnu.org> (raw)
In-Reply-To: <ab451569e4df09a1d93bece67b6b48ec8755b831.1642311162.git.leo@famulari.name> (Leo Famulari's message of "Sun, 16 Jan 2022 00:35:21 -0500")
Hi,
Leo Famulari <leo@famulari.name> skribis:
> Here's the new major release of FFmpeg.
>
> We can add it right away and move users over to it incrementally as we
> test them — having this new version is useful for people like me who use
> FFmpeg directly.
>
> Also, I always found our FFmpeg packages' use of inheritance to be
> confusing when making changes to them, so I didn't use it here.
>
> * gnu/packages/video.scm (ffmpeg-5): New variable.
Could you remove input labels? (I think ‘guix style’ can’t help because
of the conditional in the middle.)
That said, it seems to me there’s a lot of duplication here compared to
version 4. So I’d be in favor of inheriting from that one.
Now, I agree that sometimes attempting to factorize every bit can lead
to hard-to-read packages. Perhaps the solution is to duplicate and
tweak just those bits where factorization would make things less clear?
Thanks,
Ludo’.
next prev parent reply other threads:[~2022-01-24 9:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-16 5:35 [bug#53295] [PATCH] gnu: Add FFmpeg 5.0 Leo Famulari
2022-01-24 9:24 ` Ludovic Courtès [this message]
2022-05-23 17:58 ` bug#53295: " Marius Bakke
2022-05-24 1:03 ` [bug#53295] " Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmohwkp5.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=53295@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.