From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4P4XJyUvjGK2OQAAbAwnHQ (envelope-from ) for ; Tue, 24 May 2022 03:04:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id aBrtJiUvjGJmqQAAauVa8A (envelope-from ) for ; Tue, 24 May 2022 03:04:37 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2D0D4445CF for ; Tue, 24 May 2022 03:04:36 +0200 (CEST) Received: from localhost ([::1]:46402 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ntIyQ-0007RR-82 for larch@yhetil.org; Mon, 23 May 2022 21:04:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntIyE-0007R4-AY for guix-patches@gnu.org; Mon, 23 May 2022 21:04:22 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56582) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ntIxu-0003E6-7D for guix-patches@gnu.org; Mon, 23 May 2022 21:04:21 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ntIxt-00019N-T7 for guix-patches@gnu.org; Mon, 23 May 2022 21:04:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#53295] [PATCH] gnu: Add FFmpeg 5.0. Resent-From: "Leo Famulari" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 24 May 2022 01:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53295 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Marius Bakke" , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 53295-done@debbugs.gnu.org Received: via spool by 53295-done@debbugs.gnu.org id=D53295.16533542304403 (code D ref 53295); Tue, 24 May 2022 01:04:01 +0000 Received: (at 53295-done) by debbugs.gnu.org; 24 May 2022 01:03:50 +0000 Received: from localhost ([127.0.0.1]:50479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntIxi-00018x-K9 for submit@debbugs.gnu.org; Mon, 23 May 2022 21:03:50 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:45787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntIxe-00018i-9u for 53295-done@debbugs.gnu.org; Mon, 23 May 2022 21:03:49 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 3DE2F5C0273; Mon, 23 May 2022 21:03:41 -0400 (EDT) Received: from imap48 ([10.202.2.98]) by compute5.internal (MEProxy); Mon, 23 May 2022 21:03:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=mesmtp; t=1653354221; x=1653440621; bh=tBurBcRL1QaMq1p3MEIWx33LloHfQxpyOe1uA/MbDt0=; b= Ci/ZqDdQhUXsZnE330m/PNXrv6W7WgFEFdBlB2s13PydyOZc6FWqgDIF2qalFyO5 kw5H1Eqzy2WHWi6n8UU6YDFZMvlXxPC9lbcI6re1SkoARqV2wU0JxgI34RIWux/y /cLrO9M7TqSdmuu0Z6uW/giA7Plv3TrNjy0scIfVZmc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653354221; x= 1653440621; bh=tBurBcRL1QaMq1p3MEIWx33LloHfQxpyOe1uA/MbDt0=; b=t YpQuLRs68d4A06oJrZHSs2cw3uATO2OqW9U8F2jf09EM86DzCFO9yGXIWk+9MPsC WDQPvoulvbGk6uma7VgcuFXIolMMkjKxh22hPAZXvbZan9nVV4+jykQTWPIrDQaA sY+e3tSdlZfffTV62craQCPxj9uyQ7l6+CO9KvYEHtdC0XldNEe8pAUBH88w3vfU OCnntl0PEJaAIC9sPjgMIWApiAo3R3B9bXL+eRDoCaHlfIp6LWNa7PtshltZoyMR CgdhgeJDDztrVU46QiUj4yNKkj73oK7BHPj33aEccozPr+ifWqVVP1gXdoR34FpI tFGiVsjZk3hlFTJNQ6dCg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjedvgdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgfgsehtqhertderreejnecuhfhrohhmpedfnfgv ohcuhfgrmhhulhgrrhhifdcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtf frrghtthgvrhhnpeejvdelfefhueeugedutdehlefgueeuveeileevfedugeelhffhhfek hfeghfekvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 1F94031A0061; Mon, 23 May 2022 21:03:41 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-591-gfe6c3a2700-fm-20220427.001-gfe6c3a27 Mime-Version: 1.0 Message-Id: In-Reply-To: <87h75g2krt.fsf@gnu.org> References: <87pmohwkp5.fsf@gnu.org> <87h75g2krt.fsf@gnu.org> Date: Mon, 23 May 2022 21:03:20 -0400 From: "Leo Famulari" Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653354276; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=tBurBcRL1QaMq1p3MEIWx33LloHfQxpyOe1uA/MbDt0=; b=fJpckb0IiB5Kl03OPP/dSIiVuqO/o0ERPFsdQThjAuBEMoiaH/XES+OGPIvsuiXuB8I0Wk 8Y4SGSN7uYjtR7n+RtHy0mQINZKIkk7lNI7Jjw2BvsTfWN8lvGkdoynKuWQXSc6Zycgt9n 1QjakIallDzL10IjDzW6RM5fXCMs/X8awNL7KSB3oZbbvPeILED3biW92roma4/e871WF2 nX7Va3gZHFgHYPtHfBT+YHfnAfgGJUhp8H4+lrwU+G4TYuVidYRD3SJ8OaKtnDCTb5gCC4 QULi0KljzMMVTIVc2PYjckSgS3EN6sgCbKqdRwIDbgcXgcLHUxEcsdV/gtLTRA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653354276; a=rsa-sha256; cv=none; b=kTtcNKXZAMKw+jleTds59gL6PeLN+HsFnR+Kv//gl5ik8dcQ7+CmFnc3lETLASGpL2WF5o zmC7DjxqJpP8dAejI1OAL37VbgNlDS4f4M1oLuhEq/kjEU4dHlzuR4GoxCNJwcHvB4uW93 tjYwMSIp9lVNsj6u72LxgsBY15wow5qgvyvIdbKFWDJwlSvr6zCxDG4Z8/rbMBMK4fvI44 dIHsQ5mrwniHZCHny/Gv8TBySecbJG4IYEj5pgMceV/sBtMW/NUmYEj9aE3iHPENN2Hx3S LAYk8fNloy+9YfS0TeGdiP3Mn3774Oy5QywF7awk/jAdeD8+DEQc40oE/Je7lQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b="Ci/ZqDdQ"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="t YpQuLR"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.36 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b="Ci/ZqDdQ"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="t YpQuLR"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2D0D4445CF X-Spam-Score: 3.36 X-Migadu-Scanner: scn1.migadu.com X-TUID: wf0BUDCtca2k Thank you Marius! I've been distracted and busy offline so I very much a= ppreciate you finishing this work! On Mon, May 23, 2022, at 13:58, Marius Bakke wrote: > Ludovic Court=C3=A8s skriver: > >> Hi, >> >> Leo Famulari skribis: >> >>> Here's the new major release of FFmpeg. >>> >>> We can add it right away and move users over to it incrementally as = we >>> test them =E2=80=94 having this new version is useful for people lik= e me who use >>> FFmpeg directly. >>> >>> Also, I always found our FFmpeg packages' use of inheritance to be >>> confusing when making changes to them, so I didn't use it here. >>> >>> * gnu/packages/video.scm (ffmpeg-5): New variable. >> >> Could you remove input labels? (I think =E2=80=98guix style=E2=80=99= can=E2=80=99t help because >> of the conditional in the middle.) >> >> That said, it seems to me there=E2=80=99s a lot of duplication here c= ompared to >> version 4. So I=E2=80=99d be in favor of inheriting from that one. > > I went ahead and pushed this patch in 1cb10f696813ef23678029, with the > adjustments Ludo recommended + G-expressions; as well as a follow-up > that makes ffmpeg@4 inherit from it. > > Thanks Leo & Ludo! > > Attachments: > * signature.asc