From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Charles <charles.b.jackson@protonmail.com>
Cc: 49054-done@debbugs.gnu.org
Subject: bug#49054: Add borg-sans-mono Font
Date: Sat, 19 Jun 2021 19:38:47 +0200 [thread overview]
Message-ID: <b8c68baf9b2b7e1c53406bf5901c700834db9b6a.camel@student.tugraz.at> (raw)
In-Reply-To: <fXYKhPovCQturjqN1NbjPux3aOs7f9f3F3sgcOjaD1Ch_-SFSJsgF0EJqFc8zhJC6MstpuTjwZw41DYyy7fXpmhmJ50dNKm_WTL8JZHpeuY=@protonmail.com>
Am Samstag, den 19.06.2021, 16:33 +0000 schrieb Charles:
> Thank you so much for reviewing my patch, and helping me correct it.
> Attatched is an fixed version.
I've pushed your patch with some cosmetic adjustments as listed below:
- instead of appending the package to the end, I added it after
Google's Roboto fonts
- I changed the git-reference to be a two-liner
- I changed the hash to be a three-liner as otherwise there'd be
problems with smaller screens and you don't want those.
- I reworded the description a little as the old one included a typo
and to me personally didn't really get the actual idea behind the
package across.
I missed, that the commit message still didn't follow the format 100%.
I ought to have corrected it to:
gnu: Add font-borg-sans-mono.
* gnu/packages/fonts.scm (font-borg-sans-mono): New variable.
Anyway, you should now be able to pull and build the font :)
All the best,
Leo
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On Wednesday, June 16th, 2021 at 1:33 AM, Leo Prikler <
> leo.prikler@student.tugraz.at> wrote:
>
> > Am Mittwoch, den 16.06.2021, 00:53 +0000 schrieb Charles:
> >
> > > This is my first contribution, so let me know if I did something
> > >
> > > wrong. The patch is attatched.
> > > > Subject: [PATCH] gnu: Add font-borg-sans-mono
> > > >
> > > > - gnu/packages/fonts.scm (font-borg-sans-mono): Add font
> >
> > Nitpicky, but the dot in the headerline is missing and we usually
> >
> > denote new packages by "new variable" since that's what they are on
> >
> > Scheme level.
> >
> > > - (name "font-borg-sans-mono")
> > > - (version "0.3.0")
> > > - (home-page "https://github.com/charje/borg-sans-mono")
> >
> > home-page usually comes after build-system+arguments.
> >
> > > - (uri (string-append
> > >
> > >
> > > - home-page
> > >
> > >
> > > - "/releases/download/v"
> > >
> > >
> > > - version
> > >
> > >
> > > - "/borg-sans-mono.zip"))
> > >
> > >
> >
> > Please type out home-page. It could very well be, that the devs
> > start
> >
> > some fancy Github Pages website, which would break this code.
> >
> > > - (description "Droid Sans Mono Slashed + Hasklig-style
> > >
> > > ligatures!")
> >
> > This is not very descriptive at all, I'm afraid. If Hasklig or
> > Monoid
> >
> > are a reasonable alternative to this font, it's probably easier to
> > find
> >
> > a description for them.
> >
> > Regards,
> >
> > Leo
prev parent reply other threads:[~2021-06-19 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 0:53 [bug#49054] Add borg-sans-mono Font Charles via Guix-patches via
2021-06-16 6:33 ` Leo Prikler
2021-06-19 16:33 ` Charles via Guix-patches via
2021-06-19 17:38 ` Leo Prikler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8c68baf9b2b7e1c53406bf5901c700834db9b6a.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=49054-done@debbugs.gnu.org \
--cc=charles.b.jackson@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.