all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Charles via Guix-patches via <guix-patches@gnu.org>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: 49054@debbugs.gnu.org
Subject: [bug#49054] Add borg-sans-mono Font
Date: Sat, 19 Jun 2021 16:33:06 +0000	[thread overview]
Message-ID: <fXYKhPovCQturjqN1NbjPux3aOs7f9f3F3sgcOjaD1Ch_-SFSJsgF0EJqFc8zhJC6MstpuTjwZw41DYyy7fXpmhmJ50dNKm_WTL8JZHpeuY=@protonmail.com> (raw)
In-Reply-To: <71057bee331323667f1ecfdffab84aa1140665c4.camel@student.tugraz.at>

[-- Attachment #1: Type: text/plain, Size: 1606 bytes --]

Thank you so much for reviewing my patch, and helping me correct it. Attatched is an fixed version.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Wednesday, June 16th, 2021 at 1:33 AM, Leo Prikler <leo.prikler@student.tugraz.at> wrote:

> Am Mittwoch, den 16.06.2021, 00:53 +0000 schrieb Charles:
>
> > This is my first contribution, so let me know if I did something
> >
> > wrong. The patch is attatched.
>
> > > Subject: [PATCH] gnu: Add font-borg-sans-mono
> > >
> > > -   gnu/packages/fonts.scm (font-borg-sans-mono): Add font
>
> Nitpicky, but the dot in the headerline is missing and we usually
>
> denote new packages by "new variable" since that's what they are on
>
> Scheme level.
>
> > -   (name "font-borg-sans-mono")
> > -   (version "0.3.0")
> > -   (home-page "https://github.com/charje/borg-sans-mono")
>
> home-page usually comes after build-system+arguments.
>
> > -         (uri (string-append
> >
> >
> > -               home-page
> >
> >
> > -               "/releases/download/v"
> >
> >
> > -               version
> >
> >
> > -               "/borg-sans-mono.zip"))
> >
> >
>
> Please type out home-page. It could very well be, that the devs start
>
> some fancy Github Pages website, which would break this code.
>
> > -   (description "Droid Sans Mono Slashed + Hasklig-style
> >
> >     ligatures!")
>
> This is not very descriptive at all, I'm afraid. If Hasklig or Monoid
>
> are a reasonable alternative to this font, it's probably easier to find
>
> a description for them.
>
> Regards,
>
> Leo

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-new-variable-font-borg-sans-mono.patch --]
[-- Type: text/x-patch; name=0001-gnu-Add-new-variable-font-borg-sans-mono.patch, Size: 1595 bytes --]

From cbaa3be124908c9ea0b78bb607032caefb78d067 Mon Sep 17 00:00:00 2001
From: Charles <charles.b.jackson@protonmail.com>
Date: Sat, 19 Jun 2021 11:21:13 -0500
Subject: [PATCH] gnu: Add new variable font-borg-sans-mono.

* gnu/packages/fonts.scm (font-borg-sans-mono): Add new variable.
---
 gnu/packages/fonts.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 973393acc4..5d3f2a8280 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -2175,3 +2175,23 @@ neighborhood of Buenos Aires inspired Julieta Ulanovsky to design this
 typeface and rescue the beauty of urban typography that emerged in the first
 half of the twentieth century.")
     (license license:silofl1.1)))
+
+(define-public font-borg-sans-mono
+  (package
+    (name "font-borg-sans-mono")
+    (version "0.3.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/charje/borg-sans-mono/releases/download/v"
+             version
+             "/borg-sans-mono.zip"))
+       (sha256 (base32 "1xxakd9nfb8wz76rh0gbd69gh0mlqs2453g0j516xgxn8bxip2yj"))))
+    (build-system font-build-system)
+    (home-page "https://github.com/charje/borg-sans-mono")
+    (synopsis "The Borg Sans Mono font")
+    (description "Borg Sans Mono is a derivitive of Droid Sans Mono, a monospaced font
+designed for small screens. It has the additions of zero being slashed and
+programming ligatures for !=, /=, ==, ->, =>, <-, ===, and !===.")
+    (license license:asl2.0)))
-- 
2.32.0


  reply	other threads:[~2021-06-19 16:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16  0:53 [bug#49054] Add borg-sans-mono Font Charles via Guix-patches via
2021-06-16  6:33 ` Leo Prikler
2021-06-19 16:33   ` Charles via Guix-patches via [this message]
2021-06-19 17:38     ` bug#49054: " Leo Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='fXYKhPovCQturjqN1NbjPux3aOs7f9f3F3sgcOjaD1Ch_-SFSJsgF0EJqFc8zhJC6MstpuTjwZw41DYyy7fXpmhmJ50dNKm_WTL8JZHpeuY=@protonmail.com' \
    --to=guix-patches@gnu.org \
    --cc=49054@debbugs.gnu.org \
    --cc=charles.b.jackson@protonmail.com \
    --cc=leo.prikler@student.tugraz.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.