From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MI/GAeErzmCETgEAgWs5BA (envelope-from ) for ; Sat, 19 Jun 2021 19:39:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GMcUOeArzmChcAAAbx9fmQ (envelope-from ) for ; Sat, 19 Jun 2021 17:39:44 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 165202E0D0 for ; Sat, 19 Jun 2021 19:39:44 +0200 (CEST) Received: from localhost ([::1]:40346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luewY-00024A-Iq for larch@yhetil.org; Sat, 19 Jun 2021 13:39:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57110) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luevu-00020p-MN for guix-patches@gnu.org; Sat, 19 Jun 2021 13:39:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49194) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1luevu-0002yu-F9 for guix-patches@gnu.org; Sat, 19 Jun 2021 13:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1luevu-0003LL-DV for guix-patches@gnu.org; Sat, 19 Jun 2021 13:39:02 -0400 Subject: bug#49054: Add borg-sans-mono Font Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 19 Jun 2021 17:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 49054 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Charles Cc: 49054-done@debbugs.gnu.org Mail-Followup-To: 49054@debbugs.gnu.org, leo.prikler@student.tugraz.at, charles.b.jackson@protonmail.com Received: via spool by 49054-done@debbugs.gnu.org id=D49054.162412433512811 (code D ref 49054); Sat, 19 Jun 2021 17:39:02 +0000 Received: (at 49054-done) by debbugs.gnu.org; 19 Jun 2021 17:38:55 +0000 Received: from localhost ([127.0.0.1]:60740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luevm-0003KZ-Lm for submit@debbugs.gnu.org; Sat, 19 Jun 2021 13:38:54 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:38281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luevk-0003KB-AF for 49054-done@debbugs.gnu.org; Sat, 19 Jun 2021 13:38:53 -0400 Received: from nijino.local (62-116-34-49.adsl.highway.telekom.at [62.116.34.49]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4G6jh850nFz3xm8; Sat, 19 Jun 2021 19:38:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1624124328; bh=eBWb9RbmJm/sbjCbFSGQih4ztnE3pPiUJLUeRV51nF4=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=ora4dHYGTNTTJB5Bw0tyJZAG5XZSMz8GBeoTmJG7bnkVUah7VmXlh0Kc9kDpMyrPr 0UD9qGJ3nCwO5j/sFVEHWglUOrfSLUq2Np1rUbd9+hcaHrt7bCJbHkDkF1jnwCtKEH uzeGFTCHbG68H7QxHeUNZUzLU5+bgm0KcIzPM9vI= Message-ID: From: Leo Prikler Date: Sat, 19 Jun 2021 19:38:47 +0200 In-Reply-To: References: <71057bee331323667f1ecfdffab84aa1140665c4.camel@student.tugraz.at> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624124384; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=eBWb9RbmJm/sbjCbFSGQih4ztnE3pPiUJLUeRV51nF4=; b=VXUafajjaSXN/j4D8Cwq5dx1HFlIJ3J6MljzJJhbB5ZTVtuypoZyQeApJmTYVV0t8H3ofn Ds+4qLCQCzAC18h/gv2eyaQmV2sITAAHNnupRHU5FMb2enXJNnVNMwYQ70k/peZTsqeEo2 fQ6v0NeB62gKeQ/NML55bc/pBJjEusPtL85r75o9T/V4NwTQulqlOQ8HT98k4aIZDfpuOb BszQS75T7Ri7jXy+iUr2tCVedVKsxKWH8f+lgVq4AfJqUk1XFDDdqsikTiMlIy933N3lNQ Ax03J68v5Xq2wbV9lwbWhvmnN+XdOY2ioDsMmg81FgribR+wN2IVLHJlk3w/Tg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624124384; a=rsa-sha256; cv=none; b=Ibth82av/29XWMnvFj5Pp2iDII3xO09m1NEEqqA9AlyCfwnT9DNzgop3sMixyuElNdhnNo 1wEdM7D3FfrT1u9wavs6bw704OfDWJArrPwvFgeEigFoSMv2H1Gi+6jK5tp5macF1ZHQna fNrLsGcaj08DcwmZyQ++qeNbWlB6eUCo909GX2yDkWnK7mkm8j6tITLvDnelIAliiZ020+ yDdLMaWJKHaolggdR2eRsavSq2tnTcw8EY+4pdV7pvsb8izqs1f7TkRIVaqJh9rJPB1+MY uLE+3GvCBHtreHQRZgZiInUooLkNEvzai6ZjoUZ/OknRV+5nToORPo1gofeubQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=ora4dHYG; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=ora4dHYG; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 165202E0D0 X-Spam-Score: -1.32 X-Migadu-Scanner: scn1.migadu.com X-TUID: XIlkRreSRsLi Am Samstag, den 19.06.2021, 16:33 +0000 schrieb Charles: > Thank you so much for reviewing my patch, and helping me correct it. > Attatched is an fixed version. I've pushed your patch with some cosmetic adjustments as listed below: - instead of appending the package to the end, I added it after Google's Roboto fonts - I changed the git-reference to be a two-liner - I changed the hash to be a three-liner as otherwise there'd be problems with smaller screens and you don't want those. - I reworded the description a little as the old one included a typo and to me personally didn't really get the actual idea behind the package across. I missed, that the commit message still didn't follow the format 100%. I ought to have corrected it to: gnu: Add font-borg-sans-mono. * gnu/packages/fonts.scm (font-borg-sans-mono): New variable. Anyway, you should now be able to pull and build the font :) All the best, Leo > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ > > On Wednesday, June 16th, 2021 at 1:33 AM, Leo Prikler < > leo.prikler@student.tugraz.at> wrote: > > > Am Mittwoch, den 16.06.2021, 00:53 +0000 schrieb Charles: > > > > > This is my first contribution, so let me know if I did something > > > > > > wrong. The patch is attatched. > > > > Subject: [PATCH] gnu: Add font-borg-sans-mono > > > > > > > > - gnu/packages/fonts.scm (font-borg-sans-mono): Add font > > > > Nitpicky, but the dot in the headerline is missing and we usually > > > > denote new packages by "new variable" since that's what they are on > > > > Scheme level. > > > > > - (name "font-borg-sans-mono") > > > - (version "0.3.0") > > > - (home-page "https://github.com/charje/borg-sans-mono") > > > > home-page usually comes after build-system+arguments. > > > > > - (uri (string-append > > > > > > > > > - home-page > > > > > > > > > - "/releases/download/v" > > > > > > > > > - version > > > > > > > > > - "/borg-sans-mono.zip")) > > > > > > > > > > Please type out home-page. It could very well be, that the devs > > start > > > > some fancy Github Pages website, which would break this code. > > > > > - (description "Droid Sans Mono Slashed + Hasklig-style > > > > > > ligatures!") > > > > This is not very descriptive at all, I'm afraid. If Hasklig or > > Monoid > > > > are a reasonable alternative to this font, it's probably easier to > > find > > > > a description for them. > > > > Regards, > > > > Leo