From: Leo Prikler <leo.prikler@student.tugraz.at>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 49471@debbugs.gnu.org
Subject: [bug#49471] [PATCH] gnu: lld: Update to 12.0.0.
Date: Mon, 19 Jul 2021 20:10:49 +0200 [thread overview]
Message-ID: <b7dbd23a8f8ef58ee8ab44137cdc1fe1859d1c45.camel@student.tugraz.at> (raw)
In-Reply-To: <87o8aykxwn.fsf_-_@gnu.org>
Hi,
Am Montag, den 19.07.2021, 19:37 +0200 schrieb Ludovic Courtès:
> Hi,
>
> Leo Prikler <leo.prikler@student.tugraz.at> skribis:
>
> > * gnu/packages/llvm.scm (llvm-subprojects-origin, %llvm-project-
> > 12.0.0-hash):
> > New variables.
> > (lld-11, lld-12): New variables.
> > (lld): Point to lld-11.
> > ---
> > This patch is an alternative to the one sent by terramorpha.
> >
> > Supposed advantages of it are:
> > * lld still points to lld-11, not breaking any packages that rely
> > on it
> > * llvm-subprojects-origin can be reused by other LLVM subprojects
> > (think of libcxx and libcxxabi, which both require each other, or
> > libunwind, which requires libcxx)
> >
> > Disadvantages are:
> > * llvm-project is a beefy tarball and somewhat of a pain to unpack
> > * Both this version and the original use an unclean approach to
> > building
> > subprojects, that is propagated by LLVM. Perhaps we ought to
> > instead
> > clean up their mess?
>
> I’m not sure that the 2nd point means, but perhaps it can be
> addressed separately?
The gist of it is that we can't build the projects from just their
source and "normal" inputs – we have to also unpack (or leave in the
source tree as done here) other sources, that would themselves
constitute different packages.
I'm not really sure how big of a problem that is in general (apart from
the annoyance of having to do that) – it simply feels unclean, that's
all I'm complaining about here.
> > -(define-public lld
> > +(define-public lld-11
> > (package
> > (name "lld")
> > (version "11.0.0")
>
> Does it make sense to keep old versions of the linker around? To me
> it’s much less useful than keeping old versions of the compiler.
There don't seem to be dependants other than itself, but I didn't want
to accidentally break stuff, also concerning other channels. Since
lld-12 will be used in the zig package thereafter, which takes
versioned LLVM as inputs, I think it's likely similar projects might
want to use lld 11 or older, which can be built by inheriting the
somewhat simpler lld-11 package. (Similarly if you want zig 0.7 for
historical purposes, although that's entering Guix Past territory.)
> > +(define %llvm-project-12.0.0-hash
> > "0a1n88dmbwp1ww7h3ykf0s001cndk1bm3i2cj1y2sh548f4nilcy")
> ^
> I’d use ‘base32’ here (for expansion-time base32 decoding) and remove
> it from ‘llvm-subprojects-origin’.
Point taken, I'll update that in v2.
Regards,
Leo
next prev parent reply other threads:[~2021-07-19 18:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 21:39 [bug#49471] [PATCH] gnu: lld: Update to 12.0.0 terramorpha
2021-07-08 21:45 ` [bug#49471] the actual patch terramorpha
2021-07-09 22:06 ` [bug#49471] [PATCH] gnu: lld: Update to 12.0.0 Leo Prikler
2021-07-19 17:37 ` Ludovic Courtès
2021-07-19 18:10 ` Leo Prikler [this message]
2021-09-24 0:28 ` bug#49471: " Sarah Morgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7dbd23a8f8ef58ee8ab44137cdc1fe1859d1c45.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=49471@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.