From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iCRFNkDA9WCPzAAAgWs5BA (envelope-from ) for ; Mon, 19 Jul 2021 20:11:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wFoNMkDA9WCtRwAAB5/wlQ (envelope-from ) for ; Mon, 19 Jul 2021 18:11:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2327318445 for ; Mon, 19 Jul 2021 20:11:12 +0200 (CEST) Received: from localhost ([::1]:52196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5XjT-0008P5-5G for larch@yhetil.org; Mon, 19 Jul 2021 14:11:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5XjK-0008ME-Sd for guix-patches@gnu.org; Mon, 19 Jul 2021 14:11:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48738) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5XjK-0007uF-Jq for guix-patches@gnu.org; Mon, 19 Jul 2021 14:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m5XjK-0003Sg-CM for guix-patches@gnu.org; Mon, 19 Jul 2021 14:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49471] [PATCH] gnu: lld: Update to 12.0.0. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 19 Jul 2021 18:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49471 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 49471@debbugs.gnu.org Received: via spool by 49471-submit@debbugs.gnu.org id=B49471.162671825613294 (code B ref 49471); Mon, 19 Jul 2021 18:11:02 +0000 Received: (at 49471) by debbugs.gnu.org; 19 Jul 2021 18:10:56 +0000 Received: from localhost ([127.0.0.1]:60284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5XjD-0003SM-Sx for submit@debbugs.gnu.org; Mon, 19 Jul 2021 14:10:56 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:2391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5XjA-0003SC-UZ for 49471@debbugs.gnu.org; Mon, 19 Jul 2021 14:10:54 -0400 Received: from nijino.local (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GT8zF6tnDz3x8h; Mon, 19 Jul 2021 20:10:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1626718250; bh=1oAgAjm/wjcSTU9kv0e3QlI8sRlCGFMICGocaolu1kg=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=ZIG1cfEEmnQ3rxYIIymcDbqhP8aSQreBQNbL0Gl4imyIbsRZ34Tl+59HwvBzcYodT QGc+4lb5gxMMNjjaRnEyY+0HCbHFDxXJIr7szu5EJKfNE+fZSMvPF/5RLSs0hFFluz auLlVMg7SE/uwZr6k3BEqhQvZiOybjMvtLzxd0Fc= Message-ID: From: Leo Prikler Date: Mon, 19 Jul 2021 20:10:49 +0200 In-Reply-To: <87o8aykxwn.fsf_-_@gnu.org> References: <20210709220605.24524-1-leo.prikler@student.tugraz.at> <87o8aykxwn.fsf_-_@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626718272; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=1oAgAjm/wjcSTU9kv0e3QlI8sRlCGFMICGocaolu1kg=; b=cFEU9qQ8sG+xoYlJtbkFF65a0/2mwI9a/lu8aRfdLySO3LlOiYTa7PRGBRSEFH5iG0phVt W/Vpba9uUpIkephNAtohXyM1dAyrAzD8S8bLd31AbtmKYp+9vguHrSGGckeeKhEPRFD9Cd Ca9cqk+SUCngQxPwlW7fo0ZOBbaOxXIrs+PFs5WHDVPdMhgmkSRD1Ev3wQYlObxZyVqFaF 9fhfLxU5O8hjY8Ypb2Lfd0pHmUv9G8dmuDgObiQvnjqnUBBOsUHlCqg8o85MPV6ZjSqz61 vN5on/5hXzKTh9PFilud94u1fi/cttwBiCshNdBvNtGNLnOsue6J4ap9C82AcA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626718272; a=rsa-sha256; cv=none; b=NhEtCQbW959qSVSbM0AB04B6MeLBtMlsmh9ly7WLKo/g54GiD1/5qNrD4HsKXzdfwdZW5w bxRcUIMYj+mtdqK5CiyOdbouW4jY47rejzcipZUDXw7yZo4pIt300phnfSx8IIFwiVQmvD bxr40TGzzGxWMDBIxgQXNkaM3fxauQqz4RAKUipOCIDTBrR87EviW53Qh43NEVr/JiqGhu zLbvjxGCaMYJaKktbp+Itl4MPS3HwM8Kyr86Vqb0GZ5jeJiMsI0Bj6NKkuYvxxX9dzsx7L 3YRGy2pHCOxmtEr+G2na7rqF6jpv2nSGZWSpDbvx6GScyJ1U0dcsnV+n7YBgqA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=ZIG1cfEE; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=ZIG1cfEE; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 2327318445 X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: LjyM9M1Z+dzY Hi, Am Montag, den 19.07.2021, 19:37 +0200 schrieb Ludovic Courtès: > Hi, > > Leo Prikler skribis: > > > * gnu/packages/llvm.scm (llvm-subprojects-origin, %llvm-project- > > 12.0.0-hash): > > New variables. > > (lld-11, lld-12): New variables. > > (lld): Point to lld-11. > > --- > > This patch is an alternative to the one sent by terramorpha. > > > > Supposed advantages of it are: > > * lld still points to lld-11, not breaking any packages that rely > > on it > > * llvm-subprojects-origin can be reused by other LLVM subprojects > > (think of libcxx and libcxxabi, which both require each other, or > > libunwind, which requires libcxx) > > > > Disadvantages are: > > * llvm-project is a beefy tarball and somewhat of a pain to unpack > > * Both this version and the original use an unclean approach to > > building > > subprojects, that is propagated by LLVM. Perhaps we ought to > > instead > > clean up their mess? > > I’m not sure that the 2nd point means, but perhaps it can be > addressed separately? The gist of it is that we can't build the projects from just their source and "normal" inputs – we have to also unpack (or leave in the source tree as done here) other sources, that would themselves constitute different packages. I'm not really sure how big of a problem that is in general (apart from the annoyance of having to do that) – it simply feels unclean, that's all I'm complaining about here. > > -(define-public lld > > +(define-public lld-11 > > (package > > (name "lld") > > (version "11.0.0") > > Does it make sense to keep old versions of the linker around? To me > it’s much less useful than keeping old versions of the compiler. There don't seem to be dependants other than itself, but I didn't want to accidentally break stuff, also concerning other channels. Since lld-12 will be used in the zig package thereafter, which takes versioned LLVM as inputs, I think it's likely similar projects might want to use lld 11 or older, which can be built by inheriting the somewhat simpler lld-11 package. (Similarly if you want zig 0.7 for historical purposes, although that's entering Guix Past territory.) > > +(define %llvm-project-12.0.0-hash > > "0a1n88dmbwp1ww7h3ykf0s001cndk1bm3i2cj1y2sh548f4nilcy") > ^ > I’d use ‘base32’ here (for expansion-time base32 decoding) and remove > it from ‘llvm-subprojects-origin’. Point taken, I'll update that in v2. Regards, Leo