From: "Ludovic Courtès" <ludo@gnu.org>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: 49471@debbugs.gnu.org
Subject: [bug#49471] [PATCH] gnu: lld: Update to 12.0.0.
Date: Mon, 19 Jul 2021 19:37:28 +0200 [thread overview]
Message-ID: <87o8aykxwn.fsf_-_@gnu.org> (raw)
In-Reply-To: <20210709220605.24524-1-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Sat, 10 Jul 2021 00:06:06 +0200")
Hi,
Leo Prikler <leo.prikler@student.tugraz.at> skribis:
> * gnu/packages/llvm.scm (llvm-subprojects-origin, %llvm-project-12.0.0-hash):
> New variables.
> (lld-11, lld-12): New variables.
> (lld): Point to lld-11.
> ---
> This patch is an alternative to the one sent by terramorpha.
>
> Supposed advantages of it are:
> * lld still points to lld-11, not breaking any packages that rely on it
> * llvm-subprojects-origin can be reused by other LLVM subprojects
> (think of libcxx and libcxxabi, which both require each other, or
> libunwind, which requires libcxx)
>
> Disadvantages are:
> * llvm-project is a beefy tarball and somewhat of a pain to unpack
> * Both this version and the original use an unclean approach to building
> subprojects, that is propagated by LLVM. Perhaps we ought to instead
> clean up their mess?
I’m not sure that the 2nd point means, but perhaps it can be addressed
separately?
> -(define-public lld
> +(define-public lld-11
> (package
> (name "lld")
> (version "11.0.0")
Does it make sense to keep old versions of the linker around? To me
it’s much less useful than keeping old versions of the compiler.
> +(define %llvm-project-12.0.0-hash "0a1n88dmbwp1ww7h3ykf0s001cndk1bm3i2cj1y2sh548f4nilcy")
^
I’d use ‘base32’ here (for expansion-time base32 decoding) and remove it
from ‘llvm-subprojects-origin’.
Otherwise LGTM.
Thanks!
Ludo’.
next prev parent reply other threads:[~2021-07-19 17:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 21:39 [bug#49471] [PATCH] gnu: lld: Update to 12.0.0 terramorpha
2021-07-08 21:45 ` [bug#49471] the actual patch terramorpha
2021-07-09 22:06 ` [bug#49471] [PATCH] gnu: lld: Update to 12.0.0 Leo Prikler
2021-07-19 17:37 ` Ludovic Courtès [this message]
2021-07-19 18:10 ` Leo Prikler
2021-09-24 0:28 ` bug#49471: " Sarah Morgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8aykxwn.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=49471@debbugs.gnu.org \
--cc=leo.prikler@student.tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.