From: Leo Famulari <leo@famulari.name>
To: Bird <birdsite@airmail.cc>
Cc: 53388@debbugs.gnu.org
Subject: [bug#53388] New package: gallery-dl
Date: Thu, 20 Jan 2022 13:24:17 -0500 [thread overview]
Message-ID: <Yemo0VmDklixLcwV@jasmine.lan> (raw)
In-Reply-To: <85ee52fx12.fsf@airmail.cc>
On Thu, Jan 20, 2022 at 11:48:25AM +0000, Bird wrote:
> The attached patch adds a new package: gallery-dl in
> gnu/packages/video.scm
> From 799d589e6b5d76b4cac6272d22f87603729fb9e1 Mon Sep 17 00:00:00 2001
> From: Bird <birdsite@airmail.cc>
> Date: Thu, 20 Jan 2022 11:42:24 +0000
> Subject: [PATCH] gnu: gallery-dl: Add a new package. *
> gnu/packages/video.scm(gallery-dl): Add package.
Hello, and thanks for the patch!
I applied it to a Git checkout of the Guix source code, and tried
rebuilding Guix, as described here in the Contributing chapter of the
manual:
https://guix.gnu.org/manual/devel/en/html_node/Building-from-Git.html
However, it crashes like this:
------
ice-9/eval.scm:293:34: error: gpl2+: unbound variable
hint: Did you forget `(use-modules (guix licenses))'?
make[2]: *** [Makefile:7380: make-packages-go] Error 1
make[2]: Leaving directory '/home/leo/work/guix'
make[1]: *** [Makefile:6453: all-recursive] Error 1
make[1]: Leaving directory '/home/leo/work/guix'
make: *** [Makefile:3982: all] Error 2
------
The reason for this error is that licenses in the gnu/packages/video.scm
module are "prefixed" to avoid a namespace collision between packages
and licenses with the same name, such as zlib and expat:
https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/video.scm?id=f223535e1c2f052f671e44a6c546d0ebde3591b1#n80
You can check other packages in that module for examples of how to
prefix the license.
> + (license gpl2+)
I checked several of the .py files in the source code, and setup.py, and
they all seem to specify that the program is made available under the
terms of version 2 of the GPL, but no later versions. So, this package
should use "gpl2", not "gpl2+".
> + (arguments
> + '(#:tests? #f))))
We always run upstream test suites in Guix packages, because it helps
validate our packaging and finds bugs to assist upstream development.
If we do not run the tests, we add a code comment explaining why. In
Scheme, comments begin with the ; (semicolon) character.
So, can you send a revised patch that adjusts the license and either
runs the test suite or explains why not?
Thanks in advance!
next prev parent reply other threads:[~2022-01-20 21:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 11:48 [bug#53388] New package: gallery-dl Bird
2022-01-20 17:10 ` Maxime Devos
2022-01-20 17:42 ` Bird
2022-01-25 18:37 ` Leo Famulari
2022-01-20 18:24 ` Leo Famulari [this message]
2022-01-21 4:46 ` Bird
2022-01-25 18:31 ` bug#53388: " Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yemo0VmDklixLcwV@jasmine.lan \
--to=leo@famulari.name \
--cc=53388@debbugs.gnu.org \
--cc=birdsite@airmail.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.