From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YFizAhfb6WEOJwEAgWs5BA (envelope-from ) for ; Thu, 20 Jan 2022 22:58:47 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 8MsWABfb6WGjpwAA9RJhRA (envelope-from ) for ; Thu, 20 Jan 2022 22:58:47 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BC82210CF8 for ; Thu, 20 Jan 2022 22:58:45 +0100 (CET) Received: from localhost ([::1]:37960 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nAfS8-0007p3-SK for larch@yhetil.org; Thu, 20 Jan 2022 16:58:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47480) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAc7K-0005IG-EO for guix-patches@gnu.org; Thu, 20 Jan 2022 13:25:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38018) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nAc7K-0002iq-3k for guix-patches@gnu.org; Thu, 20 Jan 2022 13:25:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nAc7K-0002JP-1A for guix-patches@gnu.org; Thu, 20 Jan 2022 13:25:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53388] New package: gallery-dl Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 20 Jan 2022 18:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53388 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Bird Cc: 53388@debbugs.gnu.org Received: via spool by 53388-submit@debbugs.gnu.org id=B53388.16427030708837 (code B ref 53388); Thu, 20 Jan 2022 18:25:01 +0000 Received: (at 53388) by debbugs.gnu.org; 20 Jan 2022 18:24:30 +0000 Received: from localhost ([127.0.0.1]:59154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAc6o-0002IT-1L for submit@debbugs.gnu.org; Thu, 20 Jan 2022 13:24:30 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:43357) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAc6k-0002I0-RA for 53388@debbugs.gnu.org; Thu, 20 Jan 2022 13:24:29 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id EF96A3202010; Thu, 20 Jan 2022 13:24:20 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 20 Jan 2022 13:24:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=mesmtp; bh=070LW34WOjXmL1IeEW2M5iizC7x VK6Qf3YsGC2LXhf4=; b=CEyyhwb5VHYmQRt1Vw/8wLaxKGLYUSnL7q+75+rJCni yttGaILnPFo43cggdTe9u3lJMvPcdGyxwI8h6dFngZZQfaZRMJdhVp0Cuv3vQspv zIKPZfeJgXu0Tfc6VN6Z/8WN22BJ8BIH1jFx/5/DJZDSTyuWjp4vWhy9cv1/7UOQ = DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=070LW34WOjXmL1IeE W2M5iizC7xVK6Qf3YsGC2LXhf4=; b=bW9MV3LtOVOArFiDwFEHDwXFlC2dJX1T3 ZC33O7W0ZEX83Yx2YXcN2ptSZwFCuhoAgc2qeq4bwO20FbvzdbUjAFliEDLhPInO eHCxWTWVt9YD+lOnYBXjXzQPGgJ7jeLEXJ1riKqhlNMOpBEpe2EMxHHw8ATDkEO3 SJnMX7WaOF/0Y6sxaBi7+FGVXfRNM0v9AJFpixb6MR6RdVW4mlfdUJ4sOU4pyzBA DNfJIGI/ho/MKAj+LLwXh6CzRdkq3C1y58NV0PjpJQxbneeEraLWbhm4YHLu6odw 03LNKD1wdEkj9tKYvZKVgl28vK7n0vWHgTAncb/e/puMD/FzdKqZQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudekgdduuddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdljedmnecujfgurhepfffhvf fukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcu oehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpedvvdduge fffeeitddthfefvdeuhffgkeeikeegkeevteeghfeftefggeeuudffieenucffohhmrghi nhepghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 Jan 2022 13:24:19 -0500 (EST) Date: Thu, 20 Jan 2022 13:24:17 -0500 From: Leo Famulari Message-ID: References: <85ee52fx12.fsf@airmail.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85ee52fx12.fsf@airmail.cc> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642715926; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=070LW34WOjXmL1IeEW2M5iizC7xVK6Qf3YsGC2LXhf4=; b=YrBYWeMOCVMiss2nHhXN7IAuKpyzykiHVyCn5Tz+Ze2QZuYy7tW/9ZSP7T+5z7hc8nS/Qe SLZmNYDsPzVnGXBwgJnsTF/lpk9spMqTSjjqPkTmBxOgaoSNVU4k6bEpW5ygGOEg0vVEd0 1oHneE+bTN5ARFw3MOKkr92ldGWYM4WbWtVKXvqKPpsKjnaEZ2/EgkLXIgzZnrK1TLKWzz I9eG2CXxAc/M4i/2Qc/MYI/tUsgq4WdLeV4NaqVgK27w5IM36jTeXUtATgFnPtfigCReUZ XZkaw4MN+ZFTpjPTtcTJTTcx6TXiRu07RyIgeOMjc4Jb6+0Ab4+uXSl5QjEHLg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642715926; a=rsa-sha256; cv=none; b=Pz0FiQ5wBW3I+smq4njnR006n4tYl5uUp4v+jppUzZzwpi0jr8hhFpOFnc3u75smRhx5Oz JXeXQWjW0OUw7/ZKkndxbbEyHPrXvxgcCi4mukr7W/KTg80lG/SlVC5pOIRNwX2UE/HYFq 4YabVW0+mPunXF9mA5CmJojnOsEyqM7ybPwLARPklyxaVTs2HabYTvY5R8/X7vuNo/a3U5 nXB2E1a5BetNfyA+botEN/Yx4uAcJC4YyAcFJlJXTHTIvSDQG6vKbyXrHqqUMxnojFdIQx Ms4Kk3U4RbPYyl93G6S7JIsNsxhplS+Ki4dKfmz4rWm1CNCKWxLiJ1M3AfPO/w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=CEyyhwb5; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=bW9MV3Lt; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.02 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=CEyyhwb5; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=bW9MV3Lt; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BC82210CF8 X-Spam-Score: -3.02 X-Migadu-Scanner: scn0.migadu.com X-TUID: x9VVUoFf8f3E On Thu, Jan 20, 2022 at 11:48:25AM +0000, Bird wrote: > The attached patch adds a new package: gallery-dl in > gnu/packages/video.scm > From 799d589e6b5d76b4cac6272d22f87603729fb9e1 Mon Sep 17 00:00:00 2001 > From: Bird > Date: Thu, 20 Jan 2022 11:42:24 +0000 > Subject: [PATCH] gnu: gallery-dl: Add a new package. * > gnu/packages/video.scm(gallery-dl): Add package. Hello, and thanks for the patch! I applied it to a Git checkout of the Guix source code, and tried rebuilding Guix, as described here in the Contributing chapter of the manual: https://guix.gnu.org/manual/devel/en/html_node/Building-from-Git.html However, it crashes like this: ------ ice-9/eval.scm:293:34: error: gpl2+: unbound variable hint: Did you forget `(use-modules (guix licenses))'? make[2]: *** [Makefile:7380: make-packages-go] Error 1 make[2]: Leaving directory '/home/leo/work/guix' make[1]: *** [Makefile:6453: all-recursive] Error 1 make[1]: Leaving directory '/home/leo/work/guix' make: *** [Makefile:3982: all] Error 2 ------ The reason for this error is that licenses in the gnu/packages/video.scm module are "prefixed" to avoid a namespace collision between packages and licenses with the same name, such as zlib and expat: https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/video.scm?id=f223535e1c2f052f671e44a6c546d0ebde3591b1#n80 You can check other packages in that module for examples of how to prefix the license. > + (license gpl2+) I checked several of the .py files in the source code, and setup.py, and they all seem to specify that the program is made available under the terms of version 2 of the GPL, but no later versions. So, this package should use "gpl2", not "gpl2+". > + (arguments > + '(#:tests? #f)))) We always run upstream test suites in Guix packages, because it helps validate our packaging and finds bugs to assist upstream development. If we do not run the tests, we add a code comment explaining why. In Scheme, comments begin with the ; (semicolon) character. So, can you send a revised patch that adjusts the license and either runs the test suite or explains why not? Thanks in advance!