From: Leo Famulari <leo@famulari.name>
To: Vinicius Monego <monego@posteo.net>
Cc: 49715-done@debbugs.gnu.org, Ivan Gankevich <i.gankevich@spbu.ru>
Subject: bug#49715: [PATCH] gnu: Add gmic-qt-gimp.
Date: Fri, 22 Oct 2021 16:32:13 -0400 [thread overview]
Message-ID: <YXMfzdrHNKiKGpSK@jasmine.lan> (raw)
In-Reply-To: <50ae7ea8f8252e1b9b57c7bf31ab4cd78718f1af.camel@posteo.net>
On Fri, Oct 22, 2021 at 02:14:15PM +0000, Vinicius Monego wrote:
> Hi,
>
> > * gnu/packages/image-processing.scm (gmic-qt-gimp): New variable.
>
> I built and tested this patch and can confirm it works. A few nitpicks
> that I have:
>
> > + (inputs
> > + ;; GIMP and its dependencies.
> > + `(("gimp" ,gimp)
> > + ("gdk-pixbuf" ,gdk-pixbuf)
> > + ("cairo" ,cairo)
> > + ("gegl" ,gegl)
> > + ,@(package-inputs gmic-qt)))
>
> Should be one space below inputs. Also the labeled inputs should be
> sorted alphabetically. See the gmic-qt package for instance.
>
> > + (arguments
> > + (substitute-keyword-arguments (package-arguments gmic-qt)
> > + ((#:configure-flags flags)
> > + '(list "-DGMIC_QT_HOST=gimp" "-DENABLE_DYNAMIC_LINKING=ON"
> > + (string-append "-DGMIC_LIB_PATH="
> > + (assoc-ref %build-inputs "gmic")
> > "/lib")))))
>
> Should be one space below arguments (see gmic-qt-krita for instance).
>
> If you're using Emacs, the indentation should be fixed automatically
> with M-x indent-sexp or indent-region.
Thanks for the patch and the review, everybody!
I made the requested changes and pushed as
41492639e0223dc8fc1a357e1f9537577c055db7
prev parent reply other threads:[~2021-10-22 20:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 8:51 [bug#49715] [PATCH] gnu: Add gmic-qt-gimp Ivan Gankevich
2021-10-22 14:14 ` Vinicius Monego
2021-10-22 20:32 ` Leo Famulari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXMfzdrHNKiKGpSK@jasmine.lan \
--to=leo@famulari.name \
--cc=49715-done@debbugs.gnu.org \
--cc=i.gankevich@spbu.ru \
--cc=monego@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.