From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mLK8BwUgc2HCMAAAgWs5BA (envelope-from ) for ; Fri, 22 Oct 2021 22:33:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 8EltAwUgc2GefQAA1q6Kng (envelope-from ) for ; Fri, 22 Oct 2021 20:33:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B2BBACA24 for ; Fri, 22 Oct 2021 22:33:08 +0200 (CEST) Received: from localhost ([::1]:37052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1me1Dv-0003Ts-OH for larch@yhetil.org; Fri, 22 Oct 2021 16:33:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1me1Dq-0003Tc-Mk for guix-patches@gnu.org; Fri, 22 Oct 2021 16:33:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50534) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1me1Dq-0000qL-DH for guix-patches@gnu.org; Fri, 22 Oct 2021 16:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1me1Dq-0006Xi-7B for guix-patches@gnu.org; Fri, 22 Oct 2021 16:33:02 -0400 Subject: bug#49715: [PATCH] gnu: Add gmic-qt-gimp. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 22 Oct 2021 20:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 49715 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vinicius Monego Cc: 49715-done@debbugs.gnu.org, Ivan Gankevich Mail-Followup-To: 49715@debbugs.gnu.org, leo@famulari.name, i.gankevich@spbu.ru Received: via spool by 49715-done@debbugs.gnu.org id=D49715.163493474625102 (code D ref 49715); Fri, 22 Oct 2021 20:33:02 +0000 Received: (at 49715-done) by debbugs.gnu.org; 22 Oct 2021 20:32:26 +0000 Received: from localhost ([127.0.0.1]:33845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1me1DG-0006Wo-0k for submit@debbugs.gnu.org; Fri, 22 Oct 2021 16:32:26 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:43157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1me1DB-0006WX-2U for 49715-done@debbugs.gnu.org; Fri, 22 Oct 2021 16:32:25 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id A0F5C5C00D1; Fri, 22 Oct 2021 16:32:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 22 Oct 2021 16:32:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=EnwbtRBWLEROTSccR3fK7b+f Rrojy+tjE47qRcg37LE=; b=gETFaT7Op2lR2ereSTEdrqHYLtVxQB614sJMrVWj Nw65F5EEYz6mVISVkMxUH5kNyB3Uhs5luyI/hgNmOaapDhMjjVJYqF9OFVVyXV34 eEyU2lcst8SXEel1us3CMfqw4EqOyR0R1dlCWzWyw6VmM7RuMCoF8vCF5OmT+HLS 3CI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=EnwbtR BWLEROTSccR3fK7b+fRrojy+tjE47qRcg37LE=; b=aIBbwLtqoTOV/+ftSUQ+nf YyOaN5DDtNDkOlRb918ehzg6+gC1q6ViQh64xKdqonP/KixI6Vtd9gHdSPF3Pe7+ b6a4KV8ODmWx+oJD/brd8vTnSyL39hfYOXukjMUlTwLLsB6rf4KB+ki0zDSxpR7d MESXMc6wXI8VJxYnCJxkW5sa2HSaGfC4UF8kpW4X5n+Dolx8JYD2POmYO847uepq N35QHZzckFVk5S1HOylVGHTMBdVTTUIB53/DPDZmuXc/7X9eM+JKmywhym4SO2NG OiOL/L34b1XIHr0/JdguyvtiVqCJkKBodGsRRVRubUg/s6SOWSEU43C3BZ1b4Y2w == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddvkedgudegjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtrodttddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepgffhjeelveetueevhfehhefhvefggeevtdetteejhfeffedvhfdvtdejjeek udefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplh gvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 22 Oct 2021 16:32:15 -0400 (EDT) Date: Fri, 22 Oct 2021 16:32:13 -0400 From: Leo Famulari Message-ID: References: <20210724085155.21417-1-i.gankevich@spbu.ru> <50ae7ea8f8252e1b9b57c7bf31ab4cd78718f1af.camel@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50ae7ea8f8252e1b9b57c7bf31ab4cd78718f1af.camel@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634934788; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=EnwbtRBWLEROTSccR3fK7b+fRrojy+tjE47qRcg37LE=; b=WhOWW++PskCbuo0/JeyiIPbdE2YpNuNdLOC+CD9dtXgCmJ8AxifSzPR1mJ6SuHh2APRLiy MMb0O9qxtRYjdJKhPoDVE8cJx9Y5e7ZYh5StipDFVheqlRYzHlapn7u+aDwhclUduh7aZN pH55hgnZAv3TMyQmIOHpzK/FPNcDKD0oiN4Vz76iy5/gHx1OXvr9XVPoCq94OqgWnBKorY dWHjJx2V1Cgxxw15+P3MRDnYRS+XdN9QmxlCaqM/+p+T1eD76ZdQ1fe+vLNyR8oazGjOvS UhBp/y7yu4tpDOeE5tOKueAiYXHoIIG2XqX7BbIMMGbx68HZfHQsAfxqpNyYPA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634934788; a=rsa-sha256; cv=none; b=lDfHjD6RRGCCSc/XxraDzNnlyrhzXFrAdgjUqUJjepZ0IQuCzDaYlZMmLb5xpB3ohzOcp/ 500gIhhb9yH6bOh9W56KaZXEQJz8X0+TUemyTUvK2u4jye8SsO8vtPyRxNW5rEWeD471KT rvSgxkGe932NO8iL3OdTbhTvfTxTuy7YJiFjgU3FIaBWZVUKQUNQbfI32FzhWLrYbFDzla y6WFb3dO3tUQjIqX/QvhGjCz+RI7mED6WCX5Wha56t3FoKiyAlbyWRWFpXXQ9mfHFfnCWk nYKvpcV2ljZO4Kger6AMp+S1C6I7cdRSGof773ey57iyOY1S0FprueDpYZJ0uw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=gETFaT7O; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=aIBbwLtq; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.07 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=gETFaT7O; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=aIBbwLtq; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B2BBACA24 X-Spam-Score: 0.07 X-Migadu-Scanner: scn0.migadu.com X-TUID: MEZjfqN6lKys On Fri, Oct 22, 2021 at 02:14:15PM +0000, Vinicius Monego wrote: > Hi, > > > * gnu/packages/image-processing.scm (gmic-qt-gimp): New variable. > > I built and tested this patch and can confirm it works. A few nitpicks > that I have: > > > + (inputs > > + ;; GIMP and its dependencies. > > + `(("gimp" ,gimp) > > + ("gdk-pixbuf" ,gdk-pixbuf) > > + ("cairo" ,cairo) > > + ("gegl" ,gegl) > > + ,@(package-inputs gmic-qt))) > > Should be one space below inputs. Also the labeled inputs should be > sorted alphabetically. See the gmic-qt package for instance. > > > + (arguments > > + (substitute-keyword-arguments (package-arguments gmic-qt) > > + ((#:configure-flags flags) > > + '(list "-DGMIC_QT_HOST=gimp" "-DENABLE_DYNAMIC_LINKING=ON" > > + (string-append "-DGMIC_LIB_PATH=" > > + (assoc-ref %build-inputs "gmic") > > "/lib"))))) > > Should be one space below arguments (see gmic-qt-krita for instance). > > If you're using Emacs, the indentation should be fixed automatically > with M-x indent-sexp or indent-region. Thanks for the patch and the review, everybody! I made the requested changes and pushed as 41492639e0223dc8fc1a357e1f9537577c055db7