From: Vinicius Monego <monego@posteo.net>
To: 49715@debbugs.gnu.org
Cc: Ivan Gankevich <i.gankevich@spbu.ru>
Subject: [bug#49715] [PATCH] gnu: Add gmic-qt-gimp.
Date: Fri, 22 Oct 2021 14:14:15 +0000 [thread overview]
Message-ID: <50ae7ea8f8252e1b9b57c7bf31ab4cd78718f1af.camel@posteo.net> (raw)
In-Reply-To: <20210724085155.21417-1-i.gankevich@spbu.ru>
Hi,
> * gnu/packages/image-processing.scm (gmic-qt-gimp): New variable.
I built and tested this patch and can confirm it works. A few nitpicks
that I have:
> + (inputs
> + ;; GIMP and its dependencies.
> + `(("gimp" ,gimp)
> + ("gdk-pixbuf" ,gdk-pixbuf)
> + ("cairo" ,cairo)
> + ("gegl" ,gegl)
> + ,@(package-inputs gmic-qt)))
Should be one space below inputs. Also the labeled inputs should be
sorted alphabetically. See the gmic-qt package for instance.
> + (arguments
> + (substitute-keyword-arguments (package-arguments gmic-qt)
> + ((#:configure-flags flags)
> + '(list "-DGMIC_QT_HOST=gimp" "-DENABLE_DYNAMIC_LINKING=ON"
> + (string-append "-DGMIC_LIB_PATH="
> + (assoc-ref %build-inputs "gmic")
> "/lib")))))
Should be one space below arguments (see gmic-qt-krita for instance).
If you're using Emacs, the indentation should be fixed automatically
with M-x indent-sexp or indent-region.
Vinicius
next prev parent reply other threads:[~2021-10-22 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 8:51 [bug#49715] [PATCH] gnu: Add gmic-qt-gimp Ivan Gankevich
2021-10-22 14:14 ` Vinicius Monego [this message]
2021-10-22 20:32 ` bug#49715: " Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ae7ea8f8252e1b9b57c7bf31ab4cd78718f1af.camel@posteo.net \
--to=monego@posteo.net \
--cc=49715@debbugs.gnu.org \
--cc=i.gankevich@spbu.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.