From: Leo Famulari <leo@famulari.name>
To: Vinicius Monego <monego@posteo.net>
Cc: 47976-done@debbugs.gnu.org
Subject: bug#47976: [PATCH v2 10/10] gnu: Add orange.
Date: Sun, 25 Apr 2021 14:59:32 -0400 [thread overview]
Message-ID: <YIW8FBei/yvwvoz+@jasmine.lan> (raw)
In-Reply-To: <20210425032608.124210-10-monego@posteo.net>
On Sun, Apr 25, 2021 at 03:26:08AM +0000, Vinicius Monego wrote:
> * gnu/packages/orange.scm (orange): New variable.
Thanks for the v2 patches.
I pushed as 5461efe81f680b577cb12ba7d003e38009628b81 after making the
following changes:
> + ;; Relax some dependency versions.
> + (substitute* "requirements-gui.txt" (("PyQtWebEngine>=5.12") ""))
I rewrote this comment to explain the reason for the substitution.
Like I said, we do not change version constraints that are chosen by
upstream developers without a good reason, and so this comment was not
sufficient.
> + ("python-louvain" ,python-python-louvain)
I missed this in the first round of review but, as specified in our
manual section Python Modules, we don't name packages
"python-python-foo", but instead just "python-foo".
After I changed it, I realized that we already have a python-louvain
package.
Anyways, I changed the pre-existing python-louvain package to be called
python-louvain-0.6, adjusted its user, and renamed your package to
python-louvain.
It would be nice to check if python-scanpy, which uses
python-louvain-0.6, can instead use python-louvain.
Let us know if you want advice about how to handle this situation in the
future.
prev parent reply other threads:[~2021-04-25 19:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 17:25 [bug#47976] [PATCH 00/10] Add Orange Vinicius Monego
2021-04-23 17:28 ` [bug#47976] [PATCH 01/10] gnu: Add python-anyqt Vinicius Monego
2021-04-23 17:28 ` [bug#47976] [PATCH 02/10] gnu: Add python-pyqtgraph Vinicius Monego
2021-04-23 17:28 ` [bug#47976] [PATCH 03/10] gnu: Add python-qasync Vinicius Monego
2021-04-23 17:28 ` [bug#47976] [PATCH 04/10] gnu: Add python-orange-canvas-core Vinicius Monego
2021-04-23 17:28 ` [bug#47976] [PATCH 05/10] gnu: Add python-orange-widget-base Vinicius Monego
2021-04-23 19:20 ` Leo Famulari
2021-04-23 17:28 ` [bug#47976] [PATCH 06/10] gnu: Add python-serverfiles Vinicius Monego
2021-04-23 17:28 ` [bug#47976] [PATCH 07/10] gnu: Add python-python-louvain Vinicius Monego
2021-04-23 17:28 ` [bug#47976] [PATCH 08/10] gnu: python-pynndescent: Update to 0.5.2 Vinicius Monego
2021-04-23 17:28 ` [bug#47976] [PATCH 09/10] gnu: python-opentsne: " Vinicius Monego
2021-04-23 17:28 ` [bug#47976] [PATCH 10/10] gnu: Add orange Vinicius Monego
2021-04-23 19:25 ` Leo Famulari
2021-04-23 21:04 ` Vinicius Monego
2021-04-23 21:15 ` Leo Famulari
2021-04-23 19:29 ` [bug#47976] [PATCH 00/10] Add Orange Leo Famulari
2021-04-23 21:20 ` Vinicius Monego
2021-04-23 21:46 ` Leo Famulari
2021-04-25 3:25 ` [bug#47976] [PATCH v2 01/10] gnu: Add python-anyqt Vinicius Monego
2021-04-25 3:26 ` [bug#47976] [PATCH v2 02/10] gnu: Add python-pyqtgraph Vinicius Monego
2021-04-25 3:26 ` [bug#47976] [PATCH v2 03/10] gnu: Add python-qasync Vinicius Monego
2021-04-25 3:26 ` [bug#47976] [PATCH v2 04/10] gnu: Add python-orange-canvas-core Vinicius Monego
2021-04-25 3:26 ` [bug#47976] [PATCH v2 05/10] gnu: Add python-orange-widget-base Vinicius Monego
2021-04-25 3:26 ` [bug#47976] [PATCH v2 06/10] gnu: Add python-serverfiles Vinicius Monego
2021-04-25 3:26 ` [bug#47976] [PATCH v2 07/10] gnu: Add python-python-louvain Vinicius Monego
2021-04-25 3:26 ` [bug#47976] [PATCH v2 08/10] gnu: python-pynndescent: Update to 0.5.2 Vinicius Monego
2021-04-25 3:26 ` [bug#47976] [PATCH v2 09/10] gnu: python-opentsne: " Vinicius Monego
2021-04-25 3:26 ` [bug#47976] [PATCH v2 10/10] gnu: Add orange Vinicius Monego
2021-04-25 18:59 ` Leo Famulari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIW8FBei/yvwvoz+@jasmine.lan \
--to=leo@famulari.name \
--cc=47976-done@debbugs.gnu.org \
--cc=monego@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.