all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Vinicius Monego <monego@posteo.net>
To: Leo Famulari <leo@famulari.name>
Cc: 47976@debbugs.gnu.org
Subject: [bug#47976] [PATCH 00/10] Add Orange
Date: Fri, 23 Apr 2021 21:20:08 +0000	[thread overview]
Message-ID: <87k0osk8af.fsf@posteo.net> (raw)
In-Reply-To: <YIMgB7kEE6fc+pE4@jasmine.lan>


Leo Famulari writes:

> On Fri, Apr 23, 2021 at 05:25:47PM +0000, Vinicius Monego wrote:
>> This patchset adds the Orange data mining / data visualization / machine learning toolkit.
>> 
>> I had to disable tests for the orange widget base because unittest failed to load a file. But all tests for orange itself are passing.
>> 
>> Vinicius Monego (10):
>>   gnu: Add python-anyqt.
>>   gnu: Add python-pyqtgraph.
>>   gnu: Add python-qasync.
>>   gnu: Add python-orange-canvas-core.
>>   gnu: Add python-orange-widget-base.
>>   gnu: Add python-serverfiles.
>>   gnu: Add python-python-louvain.
>>   gnu: python-pynndescent: Update to 0.5.2.
>>   gnu: python-opentsne: Update to 0.5.2.
>>   gnu: Add orange.
>
> Thanks! I sent some comments.
>
> Otherwise, the patches look good to me, based on these standard
> assumptions:
>
> 1) You linted and built the packages
> 2) The packages are using the latest upstream versions
> 3) You checked that the licenses are correct

Thanks for the reminder. I spotted some issues.

- python-setuptools can be removed from the inputs of
  python-orange-canvas-core. The linter will also complain about
  python-docutils being propagated, but that is how it should be.
- python-qasync's license is bsd-2, not bsd-3.
- httpx doesn't need version substitution in orange (already commented
in the other reply).

Orange also states in the website that "non-code" parts are licensed
under CC-BY-SA (version not specified), if that's relevant:

https://orangedatamining.com/license/

All versions are up to date and all packages were built.

Should I send a v2 only for the affected patches?




  reply	other threads:[~2021-04-23 21:21 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23 17:25 [bug#47976] [PATCH 00/10] Add Orange Vinicius Monego
2021-04-23 17:28 ` [bug#47976] [PATCH 01/10] gnu: Add python-anyqt Vinicius Monego
2021-04-23 17:28   ` [bug#47976] [PATCH 02/10] gnu: Add python-pyqtgraph Vinicius Monego
2021-04-23 17:28   ` [bug#47976] [PATCH 03/10] gnu: Add python-qasync Vinicius Monego
2021-04-23 17:28   ` [bug#47976] [PATCH 04/10] gnu: Add python-orange-canvas-core Vinicius Monego
2021-04-23 17:28   ` [bug#47976] [PATCH 05/10] gnu: Add python-orange-widget-base Vinicius Monego
2021-04-23 19:20     ` Leo Famulari
2021-04-23 17:28   ` [bug#47976] [PATCH 06/10] gnu: Add python-serverfiles Vinicius Monego
2021-04-23 17:28   ` [bug#47976] [PATCH 07/10] gnu: Add python-python-louvain Vinicius Monego
2021-04-23 17:28   ` [bug#47976] [PATCH 08/10] gnu: python-pynndescent: Update to 0.5.2 Vinicius Monego
2021-04-23 17:28   ` [bug#47976] [PATCH 09/10] gnu: python-opentsne: " Vinicius Monego
2021-04-23 17:28   ` [bug#47976] [PATCH 10/10] gnu: Add orange Vinicius Monego
2021-04-23 19:25     ` Leo Famulari
2021-04-23 21:04       ` Vinicius Monego
2021-04-23 21:15         ` Leo Famulari
2021-04-23 19:29 ` [bug#47976] [PATCH 00/10] Add Orange Leo Famulari
2021-04-23 21:20   ` Vinicius Monego [this message]
2021-04-23 21:46     ` Leo Famulari
2021-04-25  3:25 ` [bug#47976] [PATCH v2 01/10] gnu: Add python-anyqt Vinicius Monego
2021-04-25  3:26   ` [bug#47976] [PATCH v2 02/10] gnu: Add python-pyqtgraph Vinicius Monego
2021-04-25  3:26   ` [bug#47976] [PATCH v2 03/10] gnu: Add python-qasync Vinicius Monego
2021-04-25  3:26   ` [bug#47976] [PATCH v2 04/10] gnu: Add python-orange-canvas-core Vinicius Monego
2021-04-25  3:26   ` [bug#47976] [PATCH v2 05/10] gnu: Add python-orange-widget-base Vinicius Monego
2021-04-25  3:26   ` [bug#47976] [PATCH v2 06/10] gnu: Add python-serverfiles Vinicius Monego
2021-04-25  3:26   ` [bug#47976] [PATCH v2 07/10] gnu: Add python-python-louvain Vinicius Monego
2021-04-25  3:26   ` [bug#47976] [PATCH v2 08/10] gnu: python-pynndescent: Update to 0.5.2 Vinicius Monego
2021-04-25  3:26   ` [bug#47976] [PATCH v2 09/10] gnu: python-opentsne: " Vinicius Monego
2021-04-25  3:26   ` [bug#47976] [PATCH v2 10/10] gnu: Add orange Vinicius Monego
2021-04-25 18:59     ` bug#47976: " Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0osk8af.fsf@posteo.net \
    --to=monego@posteo.net \
    --cc=47976@debbugs.gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.